Convert to MinecraftForge 1.21.1#240
Draft
Codetoil wants to merge 55 commits into
Draft
Conversation
* update template file to Java25 * remove comment * update build file * fix forge mod loading with multi release
This reverts commit 523ee93.
# Conflicts: # src/main/resources/template/build.gradle # src/main/resources/template/settings.gradle
| } | ||
|
|
||
| tasks.named("assemble") { | ||
| dependsOn(tasks.named("shadowJar")) |
Member
There was a problem hiding this comment.
This logic differs from 1.21.1-Neoforge, you're skipping the whole jvmdg output
| minecraftLibrary(shade group: 'javax.vecmath', name: 'vecmath', version: '1.5.2') | ||
| // implementation(shade group: 'at.yawk.lz4', name: 'lz4-java', version: '1.10.2') | ||
| implementation(jarJar('javax.vecmath:vecmath:1.5.2')) { | ||
| jarJar.configure(it) { |
Member
There was a problem hiding this comment.
We shade and relocate the dependencies, meaning that there maybe someone using the relocated one and it's a mismatch
Also I'm not in favor of jarinjar as I've encountered some weird bugs with it, but the bugs disappeared once switching back to shadow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description will be added when ready