Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity scaling option for bigger mobs, render them without blurring #39

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

DarkShadow44
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2025

CLA assistant check
All committers have signed the CLA.

@@ -106,12 +110,12 @@ private void drawPlayer(double drawX, double drawY, GridRenderer gridRenderer, f

if (locatorTexture != null && showHeading)
{
DrawUtil.drawEntity(drawX, drawY, heading, false, locatorTexture, alpha, drawScale, rotation);
DrawUtil.drawEntity(drawX, drawY, heading, false, locatorTexture, alpha, drawScale, rotation, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes existing functionality, please make blur configurable for entity icons. With default being true

@mysticdrew
Copy link
Member

Please Sign the CLA.
Looks good, other than entity icon blurring needs to be configurable with the default being true so users can change it how they like and the change not forced on them when the update please.

@mysticdrew
Copy link
Member

also update the changelog in the docs/changelog.html

@DarkShadow44
Copy link
Contributor Author

Thanks, updated

@mysticdrew
Copy link
Member

mysticdrew commented Jan 20, 2025

you'll need to rebase too, I merged a PR and it created a conflict.

@mysticdrew mysticdrew merged commit 52dbd25 into TeamJM:master Jan 20, 2025
2 checks passed
@mysticdrew
Copy link
Member

5.2.8 is publishing, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants