Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements to the rocket #425

Merged
merged 13 commits into from
Mar 25, 2025
Merged

Conversation

Roelymole
Copy link
Contributor

  • Rewritten the velocity calculations to account for gravity, which resolves Rocket spins around after running out of fuel #419 (or at least the main problem) as the rockets will no longer float in the air and spin around for very long before exploding.
  • Improve the random rotations when the rocket is in the LauchStage.FAILED state.
  • Allow the roll of the rocket to be changed with the shift/crouch and space/jump keys.
    • Prevent the camera angle from moving down when pressing shift in the rocket.
  • Adjust the position of the first person camera with the rotation of the rocket.
    • Change the yaw of the camera at the same rate as changing the yaw of the rocket.
    • Invert the controls when in first person mode to be more intuitive.
  • Add fire to the explosion when the atmosphere is breathable and use the crash landing damage source for a custom death message.
  • Fix issues with the rotations when the rocket is pointing downwards - I cannot figure out what is causing these issues when the rocket is pointing down, I have tried everything I can think of, so if anyone else can help me see what I am missing that would be great.
    • The player's rotations are out of sync with the rocket when changing the yaw.
    • The rocket's rotation is incorrect if the roll is non-zero.
Rocket_Gravity.mp4

@Roelymole Roelymole marked this pull request as ready for review March 25, 2025 14:52
@Roelymole Roelymole merged commit 5d4aae3 into TeamGalacticraft:main Mar 25, 2025
1 check passed
@Roelymole
Copy link
Contributor Author

The remaining tasks are not too urgent and I will deal with them eventually, but I have merged this PR now to make the rockets functional again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rocket spins around after running out of fuel
1 participant