Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added setting to disable discord message on rate limit #232

Merged
merged 1 commit into from
Mar 8, 2025
Merged

feat: added setting to disable discord message on rate limit #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ SEARCH_ACCOUNT_PATH_CACHE_TIMEOUT=600
# Critical error Discord webhook
DISCORD_WEBHOOK_ENABLED=false
DISCORD_WEBHOOK_URL=""
DISCORD_MESSAGE_ON_RATE_LIMIT=false
3 changes: 3 additions & 0 deletions app/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ class Settings(BaseSettings):
"https://github.com/TeKrop/overfast-api/issues"
)

# Enable Discord message when rate limiting is being applied
discord_message_on_rate_limit: bool = False

############
# LOCAL
############
Expand Down
9 changes: 5 additions & 4 deletions app/overfast_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ def _blizzard_forbidden_error(self) -> HTTPException:

# If Discord Webhook configuration is enabled, send a message to the
# given channel using Discord Webhook URL
send_discord_webhook_message(
"Blizzard Rate Limit reached ! Blocking further calls for "
f"{settings.blizzard_rate_limit_retry_after} seconds..."
)
if settings.discord_message_on_rate_limit:
send_discord_webhook_message(
"Blizzard Rate Limit reached ! Blocking further calls for "
f"{settings.blizzard_rate_limit_retry_after} seconds..."
)

return self._too_many_requests_response(
retry_after=settings.blizzard_rate_limit_retry_after
Expand Down