Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: save delayed state_root_hash in pbft block #2235

Merged
merged 2 commits into from
Dec 12, 2022
Merged

feat: save delayed state_root_hash in pbft block #2235

merged 2 commits into from
Dec 12, 2022

Conversation

kstdl
Copy link
Contributor

@kstdl kstdl commented Dec 6, 2022

#2234
We could use delegation_delay and remove state_root_recording_delay. But I think it is better to have it separate

@kstdl kstdl linked an issue Dec 7, 2022 that may be closed by this pull request
Save state root hash in PBFT blocks #2234
Closed
@kstdl kstdl force-pushed the save_state_root_hash branch from 59c4465 to 0c1fb25 Compare December 8, 2022 12:32
@kstdl kstdl marked this pull request as ready for review December 8, 2022 12:32
@kstdl kstdl force-pushed the save_state_root_hash branch from 0c1fb25 to 2f09e09 Compare December 9, 2022 11:17
@kstdl kstdl merged commit ba743ad into develop Dec 12, 2022
@kstdl kstdl deleted the save_state_root_hash branch December 12, 2022 11:02
@taraxadeploy
Copy link
Collaborator

prnet cleaned-up successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatusKysel MatusKysel MatusKysel approved these changes

@mfrankovi mfrankovi mfrankovi approved these changes

@JakubFornadel JakubFornadel Awaiting requested review from JakubFornadel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save state root hash in PBFT blocks
4 participants
@kstdl @taraxadeploy @MatusKysel @mfrankovi