fix: Avoid duplicate call to autoreset by removing the wrap in _queue
#6026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6025
the
onChange
in the memo options is always called once on initialization, for each model.Several models enqueue a call to
_autoResetPageIndex
(core model, sorted model, grouped model), which are all resolved together in a Promise. They should all evaluateregistered === false
.However, because the call in
getGroupedRowModel
is wrapped in another layer of_queue
:table/packages/table-core/src/utils/getGroupedRowModel.ts
Lines 168 to 173 in 0cc6992
the call to
_autoResetPageIndex
actually resolves later, onceregistered
istrue
, and it callstable.resetPageIndex()
.The wrap in
_queue
is also not present intable/packages/table-core/src/utils/getCoreRowModel.ts
Lines 78 to 80 in 0cc6992
table/packages/table-core/src/utils/getSortedRowModel.ts
Lines 117 to 119 in 0cc6992
As far as I can tell it should not be there.