fix: allow TValue to be specified in display and group column helpers

Normally, this is not an issue, since ColumnDef is contravariant with respect to TValue. However, the user might extend BaseColumnDef or another constituent of ColumnDef such that ColumnDef becomes invariant with respect to TValue. In that case, DisplayColumnDef<TData, unknown> is no longer assignable to ColumnDef<TData, TValue>. By adding TValue as a generic argument to display and group helpers, Typescript can infer the required type of TValue.
TanStack · Jul 18, 2024 · 3eb37bd · 3eb37bd
1 parent 3f0e5d2
commit 3eb37bd
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/table-core/src/columnHelper.ts b/packages/table-core/src/columnHelper.ts
@@ -66,8 +66,12 @@ export type ColumnHelper<TData extends RowData> = {
   ) => TAccessor extends AccessorFn<TData>
     ? AccessorFnColumnDef<TData, TValue>
     : AccessorKeyColumnDef<TData, TValue>
-  display: (column: DisplayColumnDef<TData>) => DisplayColumnDef<TData, unknown>
-  group: (column: GroupColumnDef<TData>) => GroupColumnDef<TData, unknown>
+  display: <TValue = unknown>(
+    column: DisplayColumnDef<TData, TValue>
+  ) => DisplayColumnDef<TData, TValue>
+  group: <TValue = unknown>(
+    column: GroupColumnDef<TData, TValue>
+  ) => GroupColumnDef<TData, TValue>
 }
 
 export function createColumnHelper<