fix(router-core): prevent infinite redirects with encoded URL params #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Normalize URLs during comparison in beforeLoad to handle encoding differences - Browser history stores encoded URLs while buildLocation may produce decoded URLs - This mismatch was causing ERR_TOO_MANY_REDIRECTS on page refresh with encoded params - Fixes infinite redirect loops when refreshing pages with special characters in URLs Fixes #4514
|
View your CI Pipeline Execution ↗ for commit 013155c
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
SeanCassiere
changed the title
tannerlinsley
requested review from
schiller-manuel and
SeanCassiere
and removed request for
schiller-manuel
There was a problem hiding this comment.
🚀
This may not be part of this fix, but should we be doing this normalization at these places as well?
LN#710 (getLocationChangeInfo -> hrefChanged).
// router-core/router.ts
// getLocationChangeInfo function
export function getLocationChangeInfo(routerState: {
// ...
}) {
// ...
const hrefChanged = fromLocation?.href !== toLocation.href // here
// ...
}LN#1642 (Router.commitLocation -> const isSameUrl).
// router-core/router.ts
// Router class
commitLocation: CommitLocationFn = ({
...next
}) => {
// ...
const isSameUrl = this.latestLocation.href === next.href // here
// ...
|
@SeanCassiere there is a new private function that was added in router.ts, as part of #4581, called comparePaths, that does some cleaning for trailing slashes before comparing them and returning either true or false depending on wether the paths match or not. your comment had me thinking we should probably add this in there and start using that more broadly. I will look into that once this gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes infinite redirect loops when refreshing pages with encoded URL parameters.
Browser history stores encoded URLs while buildLocation produces decoded URLs, causing URL mismatch in beforeLoad comparison.
Solution: Added URL normalization during comparison to ensure consistent format.
Fixes #4514