fix(react-router): fix issue with scroll restoration #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oration component behind the flag
packages/react-router/src/Match.tsx
Outdated
| @@ -113,10 +113,10 @@ export const Match = React.memo(function MatchImpl({ | |||
| </ResolvedCatchBoundary> | |||
| </ResolvedSuspenseBoundary> | |||
| </matchContext.Provider> | |||
| {parentRouteId === rootRouteId && router.options.scrollRestoration ? ( | |||
There was a problem hiding this comment.
@schiller-manuel It's just a bit strange that if I don't enable scrollRestoration, I won't be able to subscribe to onRendered router events. From my perspective, those shouldn't be connected. I'm not sure what the best solution here is. Maybe it can be just useEffect since we don't need to have access to DOM. What do you think?
There was a problem hiding this comment.
what do you need this event for?
There was a problem hiding this comment.
@schiller-manuel I don't use it in my projects, but if it's listed in API documentation, people might use it to run some side effects. It is not obvious that it only works if scrollRestoration is enabled. Also in the Solid version of the router it is not connected to the scrollRestoration feature.
There was a problem hiding this comment.
i think it's just meant as an internal event really. so for now please dont apply this change until we clarify this.
|
View your CI Pipeline Execution ↗ for commit 4fa1f74.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/create-start
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client-core
@tanstack/start-config
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
schiller-manuel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3680
It seems like
resolvedLocationdoes not always point to the latest location state in the ref callback; sometimes it points to the previous location andonRenderedis not triggered.