refactor: Make (zod|valibot|arktype)-adapter agnostic #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm we should deprecate valibot and arktype adapter since they are not required anymore. zod we still need, but just for the fallback. |
Yup, I agree. We should be able to merge this "as-is" and ask Tanner to mark @schiller-manuel maybe after devinxi we delete the zombie packages from the repo as a whole? or just throw an error asking the user to uninstall the package since it's no longer needed? |
|
wouldn't throw an error, just delete them and not publish them anymore |
👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tanstack/react-routerremains a dev dependency because it's still used in tests