Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add shouldThrow to useRouteContext options #3647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions packages/react-router/src/useRouteContext.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { useMatch } from './useMatch'
import type { ThrowConstraint } from './useMatch'
import type { AnyRouter, RegisteredRouter } from './router'
import type {
ThrowOrOptional,
UseRouteContextBaseOptions,
UseRouteContextOptions,
UseRouteContextResult,
Expand All @@ -10,20 +12,33 @@ export type UseRouteContextRoute<out TFrom> = <
TRouter extends AnyRouter = RegisteredRouter,
TSelected = unknown,
>(
opts?: UseRouteContextBaseOptions<TRouter, TFrom, true, TSelected>,
opts?: UseRouteContextBaseOptions<TRouter, TFrom, true, true, TSelected>,
) => UseRouteContextResult<TRouter, TFrom, true, TSelected>

export function useRouteContext<
TRouter extends AnyRouter = RegisteredRouter,
const TFrom extends string | undefined = undefined,
TStrict extends boolean = true,
TThrow extends boolean = true,
TSelected = unknown,
>(
opts: UseRouteContextOptions<TRouter, TFrom, TStrict, TSelected>,
): UseRouteContextResult<TRouter, TFrom, TStrict, TSelected> {
opts: UseRouteContextOptions<
TRouter,
TFrom,
TStrict,
ThrowConstraint<TStrict, TThrow>,
TSelected
>,
): ThrowOrOptional<
UseRouteContextResult<TRouter, TFrom, TStrict, TSelected>,
TThrow
> {
return useMatch({
...(opts as any),
select: (match) =>
opts.select ? opts.select(match.context) : match.context,
}) as UseRouteContextResult<TRouter, TFrom, TStrict, TSelected>
}) as ThrowOrOptional<
UseRouteContextResult<TRouter, TFrom, TStrict, TSelected>,
TThrow
>
}
6 changes: 5 additions & 1 deletion packages/react-router/tests/useRouteContext.test-d.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,12 @@ test('when there is the root context', () => {
.toEqualTypeOf<((search: { userId?: string }) => unknown) | undefined>()

expectTypeOf(
useRouteContext<DefaultRouter, '/invoices', false, number>,
useRouteContext<DefaultRouter, '/invoices', false, true, number>,
).returns.toEqualTypeOf<number>()

expectTypeOf(
useRouteContext<DefaultRouter, '/invoices', false, false, number>,
).returns.toEqualTypeOf<number | undefined>()
})

test('when there are multiple contexts', () => {
Expand Down
5 changes: 4 additions & 1 deletion packages/router-core/src/useRouteContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,23 @@ export interface UseRouteContextBaseOptions<
TRouter extends AnyRouter,
TFrom,
TStrict extends boolean,
TThrow extends boolean,
TSelected,
> {
select?: (
search: ResolveUseRouteContext<TRouter, TFrom, TStrict>,
) => TSelected
shouldThrow?: TThrow
}

export type UseRouteContextOptions<
TRouter extends AnyRouter,
TFrom extends string | undefined,
TStrict extends boolean,
TThrow extends boolean,
TSelected,
> = StrictOrFrom<TRouter, TFrom, TStrict> &
UseRouteContextBaseOptions<TRouter, TFrom, TStrict, TSelected>
UseRouteContextBaseOptions<TRouter, TFrom, TStrict, TThrow, TSelected>

export type ResolveUseRouteContext<
TRouter extends AnyRouter,
Expand Down
5 changes: 3 additions & 2 deletions packages/solid-router/src/useRouteContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@ export type UseRouteContextRoute<out TFrom> = <
TRouter extends AnyRouter = RegisteredRouter,
TSelected = unknown,
>(
opts?: UseRouteContextBaseOptions<TRouter, TFrom, true, TSelected>,
opts?: UseRouteContextBaseOptions<TRouter, TFrom, true, true, TSelected>,
) => Accessor<UseRouteContextResult<TRouter, TFrom, true, TSelected>>

export function useRouteContext<
TRouter extends AnyRouter = RegisteredRouter,
const TFrom extends string | undefined = undefined,
TStrict extends boolean = true,
TThrow extends boolean = true,
TSelected = unknown,
>(
opts: UseRouteContextOptions<TRouter, TFrom, TStrict, TSelected>,
opts: UseRouteContextOptions<TRouter, TFrom, TStrict, TThrow, TSelected>,
): Accessor<UseRouteContextResult<TRouter, TFrom, TStrict, TSelected>> {
return useMatch({
...(opts as any),
Expand Down