Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jsdoc and docs for RouterOptions #3537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ducin
Copy link
Contributor

@ducin ducin commented Feb 23, 2025

Originates in #3529 (reply in thread)

content:

  • Added jsdoc for multiple UpdatableRouteOptions params.
  • Added preloading doc for GC time.

Moreover, the preload param in UpdatableRouteOptions is invalid (bug?, see: #3526) and I added @todo, as it might be easy to forget it. Not sure what is the recommended approach here though.

@github-actions github-actions bot added documentation Everything documentation related package: react-router labels Feb 23, 2025
Copy link

nx-cloud bot commented Feb 23, 2025

View your CI Pipeline Execution ↗ for commit dbcaf17.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 4m 52s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-23 15:56:31 UTC

@ducin ducin force-pushed the router-options-jsdoc-and-doc-improvement branch from 30e2908 to dbcaf17 Compare February 23, 2025 15:50
Copy link

pkg-pr-new bot commented Feb 23, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3537

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3537

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3537

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3537

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3537

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3537

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3537

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3537

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3537

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3537

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@3537

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3537

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3537

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3537

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@3537

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3537

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3537

@tanstack/solid-cross-context

npm i https://pkg.pr.new/@tanstack/solid-cross-context@3537

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@3537

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3537

@tanstack/start-api-routes

npm i https://pkg.pr.new/@tanstack/start-api-routes@3537

@tanstack/start-client

npm i https://pkg.pr.new/@tanstack/start-client@3537

@tanstack/start-config

npm i https://pkg.pr.new/@tanstack/start-config@3537

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3537

@tanstack/start-router-manifest

npm i https://pkg.pr.new/@tanstack/start-router-manifest@3537

@tanstack/start-server

npm i https://pkg.pr.new/@tanstack/start-server@3537

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/@tanstack/start-server-functions-client@3537

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/@tanstack/start-server-functions-fetcher@3537

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/@tanstack/start-server-functions-handler@3537

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/@tanstack/start-server-functions-server@3537

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/@tanstack/start-server-functions-ssr@3537

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3537

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3537

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3537

commit: dbcaf17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything documentation related package: react-router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant