Skip to content

Conversation

gwansikk
Copy link
Contributor

@gwansikk gwansikk commented Jun 25, 2025

related: #8441

I'm the maintainer of Suspensive (a community project for React Query), who previously submitted a PR regarding React 19 support in React Query v4.

This time, I'd like to explicitly specify React 19 in the peerDependencies instead of the dependencies. React Query v4 is already compatible with React 19 without any code changes, and we've confirmed this through the following steps:

  • Built a custom tarball package(pnpm pack) with React 19 specified in peerDependencies
  • Linked the tarball in a React 19 environment for testing
  • Confirmed that it works without issues (we were able to resolve previously occurring warnings and errors)

There are no breaking changes in React 19 that affect compatibility, and v4 works reliably without special handling. If issues do arise, they would likely be due to changes in React 19, not React Query v4 itself.

Currently, since React 19 is not listed in peerDependencies, using react-query@v4 in a React 19 environment causes the following problems:

  • Peer dependency warnings are triggered by the package manager
  • Community libraries built on top of React Query v4 may face confusion when trying to support React 19

Copy link

nx-cloud bot commented Jun 25, 2025

View your CI Pipeline Execution ↗ for commit f4ee04d

Command Status Duration Result
nx affected --targets=test:lib,test:types,test:... ✅ Succeeded 2m 28s View ↗
nx affected --targets=test:lib --base=1b5c25630... ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-09 07:26:07 UTC

Copy link

codesandbox-ci bot commented Jun 25, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f4ee04d:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@gwansikk
Copy link
Contributor Author

I can't reproduce the issue in the local test environment. Is there a problem with the CI pipeline?

@gwansikk gwansikk marked this pull request as ready for review June 28, 2025 05:16
Copy link
Collaborator

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m in favor of adding React 19 to the peerDependencies of @tanstack/react-query v4.
Since it seems that @TkDodo previously opposed this change, I wanted to tag you and check if you’re okay with it before merging.

From what I understand, there’s nothing in @tanstack/react-query v4 that should cause issues with React 19.
If there are any problems, I’d expect them to be due to changes in React itself — so I think it should be safe to go ahead with the merge. Would that be alright with you?

@TkDodo
Copy link
Collaborator

TkDodo commented Jul 13, 2025

we can bump the peerDependency if everything works at runtime, but I don’t think we’re running tests against react19.

@gwansikk
Copy link
Contributor Author

I'm sorry. I'm currently going through a busy schedule. I will finish the task next week. 🙏

@multipletwigs
Copy link

@gwansikk appreciate the PR here, really timely as I'm about to do a major migration to v5 just to support React 19. Do you have any timeline on this?

@gwansikk
Copy link
Contributor Author

gwansikk commented Aug 5, 2025

@gwansikk appreciate the PR here, really timely as I'm about to do a major migration to v5 just to support React 19. Do you have any timeline on this?

The current work is in its final stages. However, in order for the PR to be merged, sufficient discussion with the maintainer is necessary.

#8441 (comment)

@gwansikk gwansikk marked this pull request as draft August 9, 2025 04:58
Copy link

coderabbitai bot commented Aug 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@gwansikk
Copy link
Contributor Author

gwansikk commented Aug 18, 2025

Latest passing test:

https://cloud.nx.app/runs/IUqpad7wPG

@gwansikk gwansikk marked this pull request as ready for review August 25, 2025 05:57
@gwansikk
Copy link
Contributor Author

NX CI is broken; all tests pass locally.

@manudeli manudeli self-assigned this Sep 1, 2025
@gwansikk
Copy link
Contributor Author

gwansikk commented Sep 5, 2025

This PR is fully prepared. Could you please take a look?
@manudeli

@gwansikk gwansikk requested a review from manudeli September 5, 2025 07:40
@manudeli
Copy link
Collaborator

manudeli commented Sep 5, 2025

This PR is fully prepared. Could you please take a look? @manudeli

I'll see this until next week.

@manudeli manudeli changed the title chore(react-query): update peer-deps for react19 in v4 feat(react-query): update peer-deps for react19 in v4 Sep 9, 2025
@manudeli manudeli changed the title feat(react-query): update peer-deps for react19 in v4 feat(react-query): add react@19 as peerDeps Sep 9, 2025
@manudeli manudeli removed the request for review from TkDodo September 9, 2025 10:05
@TanStack TanStack deleted a comment from gwansikk Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants