Skip to content

fix(pacer-devtools): remove inline style objects to fix setStyleProperty export error #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
restareaByWeezy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pacer-devtools): remove inline style objects to fix setStyleProperty export error #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/pacer-devtools/src/components/Shell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,7 @@ export function Shell() {
<div class={styles().mainContainer}>
<div
class={styles().leftPanel}
style={{
width: `${leftPanelWidth()}px`,
'min-width': '150px',
'max-width': '800px',
}}
style={`width: ${leftPanelWidth()}px`}
>
<UtilList
selectedKey={selectedKey}
Expand All @@ -94,7 +90,7 @@ export function Shell() {
onMouseDown={handleMouseDown}
/>

<div class={styles().rightPanel} style={{ flex: 1 }}>
<div class={styles().rightPanel}>
<div class={styles().panelHeader}>Details</div>
<DetailsPanel
selectedInstance={selectedInstance}
Expand Down
5 changes: 2 additions & 3 deletions packages/pacer-devtools/src/components/StateHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export function StateHeader(props: StateHeaderProps) {
return (
<div class={styles().stateHeader}>
<div class={styles().stateTitle}>{entry.type}</div>
<div style={{ display: 'flex', 'align-items': 'center', gap: '16px' }}>
<div class={styles().stateHeaderRow}>
<div class={styles().infoGrid}>
<div class={styles().infoLabel}>Key</div>
<div class={styles().infoValueMono}>{key}</div>
Expand All @@ -95,8 +95,7 @@ export function StateHeader(props: StateHeaderProps) {
</div>
</div>
<div
class={styles().infoValueMono}
style={{ 'margin-left': 'auto', 'font-weight': 'bold' }}
class={`${styles().infoValueMono} ${styles().reductionValue}`}
>
{reductionPercentage}% reduction
</div>
Expand Down
11 changes: 11 additions & 0 deletions packages/pacer-devtools/src/styles/use-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ const stylesFactory = (theme: 'light' | 'dark') => {
overflow: hidden;
min-height: 0;
flex-shrink: 0;
min-width: 150px;
max-width: 800px;
`,
rightPanel: css`
background: ${t(colors.gray[100], colors.darkGray[800])};
Expand Down Expand Up @@ -286,6 +288,15 @@ const stylesFactory = (theme: 'light' | 'dark') => {
color: ${t(colors.gray[900], colors.gray[100])};
word-break: break-all;
`,
stateHeaderRow: css`
display: flex;
align-items: center;
gap: 16px;
`,
reductionValue: css`
margin-left: auto;
font-weight: bold;
`,
noSelection: css`
flex: 1;
display: flex;
Expand Down