fix: add event.code fallback for Alt+punctuation keys on macOS#64
Open
danyi1212 wants to merge 1 commit intoTanStack:mainfrom
Open
fix: add event.code fallback for Alt+punctuation keys on macOS#64danyi1212 wants to merge 1 commit intoTanStack:mainfrom
danyi1212 wants to merge 1 commit intoTanStack:mainfrom
Conversation
On macOS, the Option (Alt) key acts as a character composer for punctuation keys (e.g., Option+- → en-dash '–'), causing event.key to differ from the expected character. This prevented Alt+punctuation hotkeys from matching. Add a PUNCTUATION_CODE_MAP that maps event.code values (Minus, Equal, Slash, BracketLeft, etc.) back to their canonical characters, following the same fallback pattern already used for letter (Key*) and digit (Digit*) codes.
🦋 Changeset detectedLatest commit: 588eb03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Option+-produces an en-dash–), causingevent.keyto differ from the expected character. This preventedAlt+punctuationhotkeys likeAlt+-,Alt+/,Alt+[, etc. from matching.PUNCTUATION_CODE_MAPinconstants.tsthat mapsevent.codevalues (Minus,Equal,Slash,BracketLeft,BracketRight,Backslash,Comma,Period,Backquote,Semicolon) to their canonical characters, following the same fallback pattern already used for letter (Key*) and digit (Digit*) codes.Alt+[whenevent.keyisDead).Fixes the issue described in the bug report where all
PUNCTUATION_KEYScombined withAlton macOS failed to match.Test plan
Alt+-,Alt+=,Alt+/,Alt+[,Alt+],Alt+\,Alt+,,Alt+., `Alt+``)Mod+Alt+-on macOS)event.codeedge casepnpm testpasses (all targets: eslint, types, lib, docs, build)