Repository navigation
Clarify Highlight registration and annotations - #24
Draft
tannerlinsley wants to merge 1 commit into
Draft
tannerlinsley wants to merge 1 commit into
tannerlinsley wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review of the README and all 33 documentation pages found imprecise statements about language registration, fallback behavior, shared definitions, and annotations. Explain what imports and registration each control, clarify configured fallbacks and retained tokenizer references, and identify diagnostic messages as application-supplied data.
Refresh current size tables with dated 1.0.0 measurements, qualify historical comparisons before their tables, and remove unsupported general cache/worker cost assertions. Update matching shipped skill prose. Implementation and API behavior are unchanged; the annotation demo's visible caption now identifies its supplied message.
Validation: typecheck, build, 33-page docs verification, 115 tests, five skill/version checks, 50 public ESM exports, ten tree-shaking bundles, publint, all seventeen size profiles, and ten benchmark profiles passed. Shiki and Sugar High comparison scripts were also rerun; timings vary by host, so historical tables remain explicitly qualified. Measurements used Node 26.3.1 and esbuild 0.28.1.
Draft for review; no release or deployment.