fix(react-form): fallback array field value during index change to prevent uncontrolled error #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event uncontrolled error
|
The problem with this is that, we're only addressing the specific value field. This is also a problem with the field meta, and all other values. :/ |
|
Hey @MVaik I just opened a PR with a proper fix for this. Feel free to take a look at it! |
|
Closing in favor of #1440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1363
More of a draft, while this seems to fix the issue it could have unintended side-effects.
Perhaps it's useful in finding a better solution.
What seems to happen:
Have at least 2 array elements that are not keyed by index.
Remove the first element.
This will cause the second element to be moved up, but it attempts to retrieve a value with the old index, resulting in an undefined value for a short bit.