-
Notifications
You must be signed in to change notification settings - Fork 52
Add support for array mutating methods in proxy change tracking #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implement proper tracking for array methods like push(), pop(), shift(), unshift(), splice(), sort(), reverse(), fill(), and copyWithin(). Previously, these methods were not intercepted by the proxy, causing changes to go untracked. - Add array method detection in proxy get trap - Update existing array tests to actually call the methods they claim to test - Add comprehensive tests for all supported array mutating methods 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: ddb37fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@tanstack/db-example-react-todo @tanstack/db
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/vue-db
commit: |
Size Change: +36 B (+0.1%) Total Size: 34.8 kB
ℹ️ View Unchanged
|
Size Change: 0 B Total Size: 1.05 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Summary
• Add proper tracking for array mutating methods (
push
,pop
,shift
,unshift
,splice
,sort
,reverse
,fill
,copyWithin
)• Fix existing array tests that were misleadingly named but didn't actually call the methods they claimed to test
• Add comprehensive test coverage for all supported array mutating methods
Test plan
🤖 Generated with Claude Code