[repro] Progressive mode avoids requestSnapshot in joins (issue #811)#1232
Closed
claude[bot] wants to merge 2 commits intomainfrom
Closed
[repro] Progressive mode avoids requestSnapshot in joins (issue #811)#1232claude[bot] wants to merge 2 commits intomainfrom
claude[bot] wants to merge 2 commits intomainfrom
Conversation
…ries (issue #811) Add regression tests to verify that progressive mode collections properly avoid calling requestSnapshot() after initial sync completes. This ensures joins between progressive collections and ordered queries work correctly. Tests verify: - Joins between two progressive collections after initial sync - Joins when joined collection is still in buffering phase - Ordered queries on progressive collections - Ordered queries with limit Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
1 task
More templates
@tanstack/angular-db
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 92 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 3.7 kB ℹ️ View Unchanged
|
Contributor
|
Closing this as it was meant as a test to check if a certain issue was solved or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds regression tests verifying that progressive mode collections properly avoid calling
requestSnapshot()after initial sync completes. This addresses the scenario described in issue #811 where joins between progressive collections would throw "Snapshot requests are not supported in full mode".What the tests verify
The tests confirm that the current code handles these scenarios correctly:
Joins between two progressive collections after initial sync - When both collections have finished their initial sync, the join should work without calling
requestSnapshot()on either collection.Joins when joined collection is still in buffering phase - When the lazy (joined) collection is still in the buffering phase, it should use
fetchSnapshot()instead ofrequestSnapshot().Ordered queries on progressive collections - Simple ordered queries (like the
useLiveSuspenseQueryexample in issue comment) work correctly without callingrequestSnapshot().Ordered queries with limit - Same behavior with limit clause.
Analysis
Based on investigation, the issue appears to have been already fixed by PR #852 (released in v0.2.4). That PR:
fetchSnapshot()during the buffering phase instead ofrequestSnapshot()requestSnapshot()callsAll tests pass, confirming the current code handles these scenarios correctly.
How to run
Related
🤖 Generated with Claude Code