Skip to content

chore: fix ci#294

Merged
AlemTuzlak merged 2 commits intomainfrom
chore/fix-ci
Feb 17, 2026
Merged

chore: fix ci#294
AlemTuzlak merged 2 commits intomainfrom
chore/fix-ci

Conversation

@AlemTuzlak
Copy link
Contributor

@AlemTuzlak AlemTuzlak commented Feb 17, 2026

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Release Notes

  • Chores

    • Added a new npm script for workspace cleanup.
  • Refactor

    • Reorganized public API exports across AI modules.
    • Removed previously exported model configuration from the ai-openai module (breaking change).
  • Tests

    • Updated test fixtures to reflect changes in stream message structure.

@AlemTuzlak AlemTuzlak requested a review from a team February 17, 2026 17:49
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

📝 Walkthrough

Walkthrough

This PR reorganizes the public API surface by removing model exports from main index files, relocates one export to a type exports section, updates test streaming chunk structures to use new type names and field conventions, and adds a comprehensive cleanup script to the root package configuration.

Changes

Cohort / File(s) Summary
Root Configuration
package.json
Added new npm script clean:all that runs git clean -fdx while preserving the .env file.
Model Export Reorganization
packages/typescript/ai-anthropic/src/index.ts, packages/typescript/ai-openai/src/index.ts
Removed public re-exports of ANTHROPIC_MODELS and OPENAI_CHAT_MODELS from main export blocks; ANTHROPIC_MODELS relocated to Type Exports section.
Test Data Structure Updates
packages/typescript/ai/tests/extend-adapter.test.ts
Updated MockTextAdapter streaming chunk types and field names: 'content' → 'TEXT_MESSAGE_CONTENT', 'done' → 'RUN_FINISHED'; renamed identifier fields (idmessageId/runId) and added explicit model field to chunks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • AlemTuzlak
  • harry-whorlow

Poem

🐰 Exports reshuffled, test chunks renamed,
Types relocated, the API reclaimed,
Clean scripts added to tidy the way,
A smaller surface to code another day! 🌿✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and lacks substance. The 'Changes' section is empty with only a placeholder comment, and no actual explanation of modifications is provided. Complete the Changes section by describing what modifications were made and their motivation. Explain the purpose of adding the clean:all script, reorganizing exports, and updating test fixtures.
Title check ❓ Inconclusive The title 'chore: fix ci' is vague and generic, using non-descriptive terms that don't convey meaningful information about the actual changes made. Provide a more specific title that describes the primary change, such as 'chore: reorganize export statements and update test fixtures' or similar to reflect the actual modifications.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Feb 17, 2026

View your CI Pipeline Execution ↗ for commit d7ee13d

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 27s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 1m 18s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-17 17:57:15 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 17, 2026

Open in StackBlitz

@tanstack/ai

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai@294

@tanstack/ai-anthropic

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-anthropic@294

@tanstack/ai-client

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-client@294

@tanstack/ai-devtools-core

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-devtools-core@294

@tanstack/ai-fal

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-fal@294

@tanstack/ai-gemini

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-gemini@294

@tanstack/ai-grok

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-grok@294

@tanstack/ai-ollama

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-ollama@294

@tanstack/ai-openai

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-openai@294

@tanstack/ai-openrouter

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-openrouter@294

@tanstack/ai-preact

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-preact@294

@tanstack/ai-react

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-react@294

@tanstack/ai-react-ui

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-react-ui@294

@tanstack/ai-solid

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-solid@294

@tanstack/ai-solid-ui

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-solid-ui@294

@tanstack/ai-svelte

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-svelte@294

@tanstack/ai-vue

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-vue@294

@tanstack/ai-vue-ui

npm i https://pkg.pr.new/TanStack/ai/@tanstack/ai-vue-ui@294

@tanstack/preact-ai-devtools

npm i https://pkg.pr.new/TanStack/ai/@tanstack/preact-ai-devtools@294

@tanstack/react-ai-devtools

npm i https://pkg.pr.new/TanStack/ai/@tanstack/react-ai-devtools@294

@tanstack/solid-ai-devtools

npm i https://pkg.pr.new/TanStack/ai/@tanstack/solid-ai-devtools@294

commit: d7ee13d

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 17: The "clean:all" npm script currently uses --exclude="!.env" which
negates the pattern and makes .env eligible for deletion; update the "clean:all"
script (script name: clean:all) to use --exclude=".env" (remove the leading "!")
so the .env file is preserved by git clean.

},
"scripts": {
"clean": "pnpm --filter \"./packages/**\" run clean",
"clean:all": "git clean -fdx --exclude=\"!.env\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify git clean --exclude behavior with both patterns

cd "$(mktemp -d)"
git init test-repo && cd test-repo

# Setup: Create tracked and untracked files
echo "hello" > tracked.txt
git add tracked.txt && git commit -m "init"

echo "SECRET=123" > .env
echo "untracked" > untracked.txt

echo "=== Test 1: --exclude=\"!.env\" (current code) ==="
echo "Before cleanup (--exclude='!.env'):"
ls -la | grep -E '\.env|untracked'

# Use --dry-run to see what would be deleted
echo -e "\nWhat git clean would delete (--exclude='!.env'):"
git clean -fdx --exclude="!.env" --dry-run 2>&1 | head -20

echo ""
echo "=== Test 2: --exclude=\".env\" (proposed fix) ==="
# Reset for clean state
echo "SECRET=123" > .env
echo "untracked" > untracked.txt

echo "Before cleanup (--exclude='.env'):"
ls -la | grep -E '\.env|untracked'

echo -e "\nWhat git clean would delete (--exclude='.env'):"
git clean -fdx --exclude=".env" --dry-run 2>&1 | head -20

echo ""
echo "=== Test 3: No exclude (baseline) ==="
echo "SECRET=123" > .env
echo "untracked" > untracked.txt

echo -e "\nWhat git clean would delete (no exclude):"
git clean -fdx --dry-run 2>&1 | head -20

Repository: TanStack/ai

Length of output: 1721


--exclude="!.env" does not preserve .env — remove the ! negation prefix.

git clean --exclude=PATTERN uses gitignore-style pattern matching. The ! prefix negates the pattern, so --exclude="!.env" makes .env eligible for deletion instead of protecting it. The pattern should be .env without the negation.

Proposed fix
-    "clean:all": "git clean -fdx --exclude=\"!.env\"",
+    "clean:all": "git clean -fdx --exclude=.env",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"clean:all": "git clean -fdx --exclude=\"!.env\"",
"clean:all": "git clean -fdx --exclude=.env",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 17, The "clean:all" npm script currently uses
--exclude="!.env" which negates the pattern and makes .env eligible for
deletion; update the "clean:all" script (script name: clean:all) to use
--exclude=".env" (remove the leading "!") so the .env file is preserved by git
clean.

@AlemTuzlak AlemTuzlak merged commit c3a1dad into main Feb 17, 2026
6 checks passed
@AlemTuzlak AlemTuzlak deleted the chore/fix-ci branch February 17, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments