Skip to content

Commit

Permalink
chore(build): Enable all warnings on qTox libraries as well
Browse files Browse the repository at this point in the history
warnings interface was only being linked to qtox_static, so were not being
applied to e.g. util. Link it to each library as well as qtox_static so that
they all inherit all the warnings.
  • Loading branch information
anthonybilinski committed Mar 24, 2022
1 parent 9da8ec9 commit 0d366a5
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -626,10 +626,10 @@ target_link_libraries(${PROJECT_NAME}_static
${ALL_LIBRARIES}
coverage_config)

target_link_libraries(${PROJECT_NAME}_static qtox::warnings)
target_link_libraries(${PROJECT_NAME}_static util_library)
target_link_libraries(${PROJECT_NAME}_static audio_library)
target_link_libraries(${PROJECT_NAME}_static translations_library)
target_link_libraries(${PROJECT_NAME}_static qtox::warnings)

add_executable(${PROJECT_NAME}
WIN32
Expand Down
1 change: 1 addition & 0 deletions audio/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,4 @@ target_include_directories(audio_library PUBLIC include/)
target_link_libraries(audio_library util_library)
target_link_libraries(audio_library Qt5::Core)
target_link_libraries(audio_library ${OPENAL_LIBRARIES})
target_link_libraries(audio_library qtox::warnings)
3 changes: 2 additions & 1 deletion test/mock/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ target_link_libraries(mock_library
util_library
Qt5::Core
Qt5::Network
Qt5::Gui)
Qt5::Gui
qtox::warnings)
1 change: 1 addition & 0 deletions util/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ add_library(util_library STATIC
# We need this directory, and users of our library will need it too
target_include_directories(util_library PUBLIC include/)
target_link_libraries(util_library PRIVATE Qt5::Core)
target_link_libraries(util_library PRIVATE qtox::warnings)

0 comments on commit 0d366a5

Please sign in to comment.