Open
Conversation
Member
|
多谢你的关注和 PR,修改的内容有点多,我花一些时间研究下你的代码。 |
wxnet2013
reviewed
Jan 21, 2019
| "@rxloop/immer": "^0.1.5", | ||
| "@rxloop/loading": "^0.2.2", | ||
| "babel-core": "^7.0.0-beta.3", | ||
| "babel-core": "^7.0.0-bridge.0", |
Member
There was a problem hiding this comment.
7.0.0-bridge.0 是 beta.3 的上一个版本,这里降低版本的原因是什么呢?
Author
There was a problem hiding this comment.
好像在我的 vscode 里 debug 有问题, 而且我看 https://jestjs.io/docs/en/getting-started#using-babel这样设置的.
放在单独的 package 也挺好, 毕竟不是每个人都需要这个 decorator. 但我觉得可以用 lerna 管理多个包, 放在同一个仓库里.
Member
There was a problem hiding this comment.
目前主要精力在 1.x ,验证方案和场景的匹配度,之后 2.x 会用 TS 重写并用 lerna 管理这些分散的 npm 包。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: #8