fix: support WebP thumbnails inside ZIP archives#1387
Open
yosofbadr wants to merge 1 commit into
Open
Conversation
yosofbadr
changed the title
CyanVoxel
added
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1364 by allowing WebP images inside ZIP/CBZ archives to be used as thumbnails.
Changes
.webpto archive thumbnail image extension checks.Testing
uv run --extra pytest pytest tests/qt/test_thumb_renderer.py -quv run --extra ruff ruff check src/tagstudio/qt/previews/renderer.py tests/qt/test_thumb_renderer.pyuv run --extra ruff ruff format --check src/tagstudio/qt/previews/renderer.py tests/qt/test_thumb_renderer.pyNotes
A full test suite run was not used for this focused change because the local baseline
python -m pytestcommand was already failing in setup. The affected thumbnail renderer path is covered by the targeted regression tests above.