[BUGFIX] Allow the slash in composer name interlinks to be replaced b… #1070
Conversation
| { | ||
| // core | ||
| yield 'core no version' => ['typo3/cms-adminpanel', 'core', 'typo3', 'cms-adminpanel', null]; | ||
| yield 'core with version' => ['typo3/cms-adminpanel/13.4', 'core', 'typo3', 'cms-adminpanel', '13.4']; |
There was a problem hiding this comment.
Should we also have typo3/[email protected]?! I don't remember the slash notation for this?
There was a problem hiding this comment.
Should we do a search if we ever used the typo3/cms-adminpanel/13.4 notation anywhere? Issue is we had tests who testet that this worked before this change. I have no idea if we ever really used it..
| // default inventories | ||
| yield 'default inventory' => ['t3coreapi', 'default', 'typo3', 't3coreapi', null]; | ||
| yield 'default inventory with explicit version' => ['t3coreapi/12.4', 'default', 'typo3', 't3coreapi', '12.4']; | ||
| yield 'default inventory with @stable' => ['t3coreapi@stable', 'default', 'typo3', 't3coreapi', 'stable']; |
There was a problem hiding this comment.
Also a test for @main / @12.4?
There was a problem hiding this comment.
Phew, this is/was really hard for me to review. I'm leaning a bit towards "let's try this in production and see what caves in".
We should wait for next Tuesdays TYPO3 release and probably merge this the week after, to carefully review what'll happen and be able to adjust?
2 participants
…y a dash
See also: https://review.typo3.org/c/Packages/TYPO3.CMS/+/90818