[feature] add the ability to recover shuffling datasets in checkpoint. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[fix] bug fixed, epoch for load checkpoint cannot exceed the config one.
|
check failed. |
LongzhuoWang
force-pushed
the
feature/checkpoint
branch
from
89d498a to
aa99a07
Compare
[feature] add cache deletion function. [fix] Fixed bug and improved feature.
yezhengmao1
requested changes
Sep 13, 2024
mlora/executor/task/task.py
Outdated
| data = preprocess_func[preprocess_type](data) | ||
| # If data preprocess_type is shuffle, create a cache folder, | ||
| # to store shuffled data and use it for saving checkpoints. | ||
| if preprocess_type == "shuffle": |
There was a problem hiding this comment.
can we put the function into line 97 or create a new function?
There was a problem hiding this comment.
maybe it's better to avoid using the "if" branch here because different process_type have different process functions defined in line 94.
There was a problem hiding this comment.
OK, let me have a try.
There was a problem hiding this comment.
good idea, this is indeed better. I have already modified the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feature] add the ability to recover shuffling datasets in checkpoint.
[fix] bug fixed, epoch for load checkpoint cannot exceed the config one.