-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #848: Translate Time to Leave to Swedish (sv-SE) #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wonkyung this looks mostly done, I've left just a few line notes for you to check!
Codecov Report
@@ Coverage Diff @@
## main #852 +/- ##
=======================================
Coverage 59.25% 59.25%
=======================================
Files 26 26
Lines 2086 2086
Branches 306 306
=======================================
Hits 1236 1236
Misses 850 850 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks all good!
Is there anything I can do to resolve the test failures? |
\changelog-update |
No, there wasn't anything left @wonkyung, just us being busy :) Thanks for translating Time to Leave to Swedish. If we ever get new or updated strings in Swedish can we mention you for help? |
Sure @tupaschoal, anytime! |
Thanks! |
Related issue
Closes #848
Context / Background
I have added translation to Swedish of the application.
What change is being introduced by this PR?
I have followed the guidelines provided in the issue #475 and the guidelines provided for development. And it all went smoothely.
How will this be tested?