Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #848: Translate Time to Leave to Swedish (sv-SE) #852

Merged
merged 5 commits into from
Oct 15, 2022

Conversation

wonkyung
Copy link
Contributor

@wonkyung wonkyung commented Oct 9, 2022

Related issue

Closes #848

Context / Background

I have added translation to Swedish of the application.

What change is being introduced by this PR?

I have followed the guidelines provided in the issue #475 and the guidelines provided for development. And it all went smoothely.

How will this be tested?


  • [ X] I confirm I'm a native or fluent speaker of the language I'm translating to.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wonkyung this looks mostly done, I've left just a few line notes for you to check!

docs/README-sv-SE.md Outdated Show resolved Hide resolved
locales/sv-SE/translation.json Outdated Show resolved Hide resolved
locales/sv-SE/translation.json Outdated Show resolved Hide resolved
locales/sv-SE/translation.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #852 (7b72fa5) into main (b0650fc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   59.25%   59.25%           
=======================================
  Files          26       26           
  Lines        2086     2086           
  Branches      306      306           
=======================================
  Hits         1236     1236           
  Misses        850      850           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor Author

@wonkyung wonkyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks all good!

@wonkyung
Copy link
Contributor Author

Is there anything I can do to resolve the test failures?
I don't quite understand what to do here.

@tupaschoal
Copy link
Collaborator

\changelog-update
Message: Translation: Time to Leave is now available in Swedish (sv-SE)!

@tupaschoal tupaschoal changed the title feat: add translations for Swedish locale sv-SE Close #848: Translate Time to Leave to Swedish (sv-SE) Oct 15, 2022
@tupaschoal tupaschoal merged commit 2bb9d67 into TTLApp:main Oct 15, 2022
@tupaschoal
Copy link
Collaborator

tupaschoal commented Oct 15, 2022

Is there anything I can do to resolve the test failures? I don't quite understand what to do here.

No, there wasn't anything left @wonkyung, just us being busy :)

Thanks for translating Time to Leave to Swedish. If we ever get new or updated strings in Swedish can we mention you for help?

@wonkyung
Copy link
Contributor Author

Sure @tupaschoal, anytime!

@tupaschoal
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate Time To Leave to Swedish sv_SE
2 participants