Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make images and icons not draggable #1025

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

Karroteu
Copy link
Contributor

@Karroteu Karroteu commented Oct 25, 2023

Makes images and icons not draggable within the app

Related issue

Closes #1028

Context / Background

Makes images and icons with class .th and logo not draggable within the app

What change is being introduced by this PR?

Slight UX improvement

How will this be tested?

No need for testing, has little impact on usability of the app, though I've tested it locally


  • I confirm I'm a native or fluent speaker of the language I'm translating to.

@araujoarthur0
Copy link
Collaborator

Hi @Karroteu, this look like an interesting improvement!
Could you please ensure you create a bug for tracking before submitting a PR?

Also, please revert the changes in package lock since they don't seem related.

@Karroteu
Copy link
Contributor Author

Karroteu commented Oct 30, 2023

Sorry i didn't mean to delete the file. I'm new to this. Would you be able to revert the change please?
I'e created an issue for this pull request but im unable to assign it to this pr @araujoarthur0

@araujoarthur0
Copy link
Collaborator

You can assign the issue by editing the description and adding a "Closes #" string to it. You can check other PRs to see it being done.

Also, to revert this change you can use git reset --soft HEAD~ to undo the last commit, unstage the change and then commit again. After that you can git push --force this branch to replace the changes here.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e25523f) 75.04% compared to head (76edc70) 79.37%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   75.04%   79.37%   +4.32%     
==========================================
  Files          26       21       -5     
  Lines        2188     1275     -913     
  Branches      345      189     -156     
==========================================
- Hits         1642     1012     -630     
+ Misses        546      263     -283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the package-lock change and tested that it works as intended. @araujoarthur0 do you want to test or add anything else?

@tupaschoal tupaschoal merged commit 9c14796 into TTLApp:main Dec 23, 2023
8 checks passed
@tupaschoal
Copy link
Collaborator

\changelog-update
Message: Fix [#1028]: Make images and icons not draggable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX by not allowing the user to drag icons and images within the app
3 participants