-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make images and icons not draggable #1025
Conversation
Hi @Karroteu, this look like an interesting improvement! Also, please revert the changes in package lock since they don't seem related. |
Sorry i didn't mean to delete the file. I'm new to this. Would you be able to revert the change please? |
You can assign the issue by editing the description and adding a "Closes #" string to it. You can check other PRs to see it being done. Also, to revert this change you can use |
Co-Authored-By: maks <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 75.04% 79.37% +4.32%
==========================================
Files 26 21 -5
Lines 2188 1275 -913
Branches 345 189 -156
==========================================
- Hits 1642 1012 -630
+ Misses 546 263 -283 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the package-lock change and tested that it works as intended. @araujoarthur0 do you want to test or add anything else?
\changelog-update |
Makes images and icons not draggable within the app
Related issue
Closes #1028
Context / Background
Makes images and icons with class .th and logo not draggable within the app
What change is being introduced by this PR?
Slight UX improvement
How will this be tested?
No need for testing, has little impact on usability of the app, though I've tested it locally