-
-
Notifications
You must be signed in to change notification settings - Fork 290
feat(starr-anime): Major overhaul to Anime BD Tiers #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR overhauls the Anime BD tier definitions by reassigning release groups based on up-to-date SeaDex statistics, validating and pruning low-impact groups, and standardizing tier naming conventions across all Radarr and Sonarr JSON configurations. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider automating the JSON tier generation (e.g., via a script or CI step) to ensure consistency between Radarr and Sonarr files and reduce manual errors in future updates.
- Verify that renaming the tier files (removing references like “SeaDex muxers” and “FanSubs”) doesn’t break any existing collection filter references or lookup logic elsewhere in the codebase.
- It would help to include a summary of how many groups moved between tiers (or overall counts per tier) so reviewers can easily spot any unexpected migrations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider automating the JSON tier generation (e.g., via a script or CI step) to ensure consistency between Radarr and Sonarr files and reduce manual errors in future updates.
- Verify that renaming the tier files (removing references like “SeaDex muxers” and “FanSubs”) doesn’t break any existing collection filter references or lookup logic elsewhere in the codebase.
- It would help to include a summary of how many groups moved between tiers (or overall counts per tier) so reviewers can easily spot any unexpected migrations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Deploying with ⚡ Cloudflare Pages
|
|
Deploying with ⚡ Cloudflare Pages
|
|
Deploying with ⚡ Cloudflare Pages
|
Pull Request
Purpose
As time has passed, various new anime groups have popped up, and older groups are having their releases trumped. Also, SeaDex now offers a way to properly pull stats for each release group. This brings the tiers in line as much as possible with the current SeaDex.
Approach
I went in and pulled the top 200 groups by counts of total releases, best dual releases, and best alt releases. I then tiered them based on how often they would end up as the best release and penalized them if they had mostly alt releases that were then being trumped by one of the other groups. Groups with only best releases, even lower counts, were also given a slight boost since they would have specialized releases that filled a niche without being trumped, e.g. SoM and FateSucks. Since a best dual audio release is a best release, this also meant that the top tiers included mostly dual audio groups. This did not penalize any groups with the potential exceptions of MTBB and Okay-Subs who went from Tier 2 to Tier 3.
If a group existed within the CFs but not in the new tiers, I validated their releases on Sneedex and Seadex and made sure they did not have more than 1 best release. Most groups were either fansubs or had alt releases that were being trumped by groups elsewhere in the CFs. If a group only had a single best release or no best releases, I did not include them as these shows can be manually handled by users (less maintenance in the guides).
Open Questions and Pre-Merge TODOs
Please review this since there are major changes, and I might have made slight typos and mistakes. Also, I changed the name of the tiers to stop saying stuff like SeaDex muxers, FanSubs, etc. since that no longer applies. I have no idea if this breaks other things, the files themselves have that in their name. We can revert that, or someone else can help make the other changes needed to swap the CF names.
Requirements
Summary by Sourcery
Overhaul anime Blu-ray tier configurations across Radarr and Sonarr using updated SeaDex statistics, renaming tiers and reassigning release groups to align with current activity and quality hierarchy.
Enhancements: