Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add installer scripts and cargo-dist #4

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add installer scripts and cargo-dist #4

wants to merge 4 commits into from

Conversation

ThomasTNO
Copy link
Contributor

@ThomasTNO ThomasTNO commented Feb 11, 2025

Todo:
Interesting commands to support

  • Add SBOM (similar to what we did in WuppieFuzz?)
  • Add License (similar to what we did in WuppieFuzz?)
  • Add version (similar to what we did in WuppieFuzz?)

Furthermore,

  • Check license compatibility
  • Test if it works 👯
  • Update README including requirements on Docker.
  • ..?

Copy link

github-actions bot commented Feb 11, 2025

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 4.0 stars

Show details

Sigrid compared your code against the baseline of 2025-02-11.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 5 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
WuppieFuzz-dashboard/src/docker_util.rs (lines 137-143)
WuppieFuzz-dashboard/src/docker_util.rs (lines 152-158)
🟠 Unit Size
(Introduced)
WuppieFuzz-dashboard/src/main.rs
main()
🟡 Unit Size
(Introduced)
WuppieFuzz-dashboard/src/embed_files.rs
extract_entry(include_dir,any,Path)
🟡 Unit Complexity
(Introduced)
WuppieFuzz-dashboard/src/embed_files.rs
extract_entry(include_dir,any,Path)
🟡 Unit Interfacing
(Introduced)
WuppieFuzz-dashboard/src/embed_files.rs
extract_entry(include_dir,any,Path)

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-02-11 Before changes New/changed code
Volume 5.4 N/A N/A
Duplication 4.0 N/A 3.8
Unit Size 2.1 N/A 3.6
Unit Complexity 2.4 N/A 4.0
Unit Interfacing 1.9 N/A 3.7
Module Coupling 3.3 N/A 5.5
Component Independence 5.4 N/A N/A
Component Entanglement N/A N/A N/A
Maintainability 3.6 N/A 4.2

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

}

if is_container_running(docker, container_name).await {
println!("Grafana container is already running.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
println!("Grafana container is already running.");
println!("WuppieFuzz dashboard is already running.");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same holds for other println with Grafana container, maybe do a find replace?

// Start the container
docker.start_container(&container_id).await.unwrap();

println!("Grafana container started successfully.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should also print how to access the dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants