-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add installer scripts and cargo-dist #4
base: main
Are you sure you want to change the base?
Conversation
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 4.0 stars Show detailsSigrid compared your code against the baseline of 2025-02-11. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
} | ||
|
||
if is_container_running(docker, container_name).await { | ||
println!("Grafana container is already running."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
println!("Grafana container is already running."); | |
println!("WuppieFuzz dashboard is already running."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same holds for other println with Grafana container, maybe do a find replace?
// Start the container | ||
docker.start_container(&container_id).await.unwrap(); | ||
|
||
println!("Grafana container started successfully."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we should also print how to access the dashboard
Todo:
Interesting commands to support
Furthermore,