Skip to content

Conversation

MeikelLP
Copy link
Contributor

@MeikelLP MeikelLP commented Aug 7, 2025

closes #371

I basically copied xUnitV3 and replaced XUnit calls with TUnit calls. I don't know if this is the correct way to do it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.57%. Comparing base (d2f7e9e) to head (3407e42).

❗ There is a different number of reports uploaded between BASE (d2f7e9e) and HEAD (3407e42). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d2f7e9e) HEAD (3407e42)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   63.22%   55.57%   -7.66%     
==========================================
  Files         257      257              
  Lines       26391    23038    -3353     
  Branches     2601     1897     -704     
==========================================
- Hits        16687    12803    -3884     
- Misses       9189     9765     +576     
+ Partials      515      470      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderlinne
Copy link
Collaborator

Thank you for submitting this pull request, could you please sign-off you commit and format the code?

@MeikelLP
Copy link
Contributor Author

Should be fixed now

@alexanderlinne
Copy link
Collaborator

The formatting error is fixed, your commit also needs to be signed off

@MeikelLP
Copy link
Contributor Author

What do you mean by "signed-off"? My commit is signed with my gpg key and verified by Github as you can clearly see on the commits tab

image

@alexanderlinne
Copy link
Collaborator

Ah, sorry for the confusion. GPG signing is something different than sign-off. You can simply run git commit --amend --signoff --no-edit and will get the required result. You can read about it here: https://docs.github.com/en/organizations/managing-organization-settings/managing-the-commit-signoff-policy-for-your-organization

Signed-off-by: Meikel Philipp <[email protected]>
@MeikelLP
Copy link
Contributor Author

I guess I did it now?

Kinda high barrier for an open source project. Feels like a company internal requirement not an volunteer contributor requirement 👀

@alexanderlinne alexanderlinne changed the title feat: add TUnit Add TUnit Support Aug 22, 2025
@alexanderlinne alexanderlinne merged commit 7e33439 into TNG:main Aug 22, 2025
9 checks passed
@MeikelLP MeikelLP deleted the feature/tunit branch August 22, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TUnit
3 participants