Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Exercises complete #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pollygee
Copy link

Answers to worded questions in answers.md, coding inside files. There is an alternative solution for 6.rb but that can be ignored it's less efficient than my main solution.

@jamesdabbs
Copy link
Member

👍 Your is_palindrome? function does return nil instead of false if the string is short. That's weird, but assuming you're just doing if is_palindrome?(...) it isn't necessarily a problem. Other than that, looks good.

@pollygee
Copy link
Author

yes I didn't really read it that way - I didn't really think that if it
wasn't it needed to return false, I was just thinking it would only check *if

  • it had enough characters.

Good point though, I caught it during lecture and changed it on my file.
Thanks!

On Mon, May 18, 2015 at 3:04 PM, James Dabbs [email protected]
wrote:

[image: 👍] Your is_palindrome? function does return nil instead of
false if the string is short. That's weird, but assuming you're just
doing if is_palindrome?(...) it isn't necessarily a problem. Other than
that, looks good.


Reply to this email directly or view it on GitHub
#3 (comment)
.

Cheers,
Polly Sileo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants