Implement @hcayless solution #1 for issue @2246 — do not test @spanTo across files
#2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update tests to match.
ebeshero
changed the title
@spanTo across files@spanTo across files
martindholmes
approved these changes
Jan 20, 2025
ebeshero
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
I just pulled in this branch, ran tests and built exemplars so I could see the built RelaxNG. I tested that new version against a local TEI file with a @spanTo that points into external file rather than to a following anchor, and all works as expected. The new version successfully loosens the constraint so we can do this without a validation error. And the new version of the Schematron also works to validate a pointer to a following anchor inside the file. So all's good!
|
With two positive reviews and a refridge period beginning, I'm just going ahead and merging this now to dev. |
ebeshero
deleted the
sydb_2246_check_spanning_only_in_current_document
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since no one has discussed this further in over 2 years, I just went ahead and changed the Schematron (as proposed on the issue) to only test that the target element follows the current element iff the
@spanTostarts with ‘#’. I used (what I think) is an easier-to-understand XPath, though.This is not an ideal solution, of course, because (IMHO) we should allow a user to put whitespace in the attr value and still get the test (i.e., we should use normalize-space() in the code). Also, doesn’t
.#duckalso point to the element with ID "duck"? For that matter, doesn’t../me.xml#duckpoint to it if the current file happens to be called me.xml?