use <constraintDecl> in Guidelines and tei_customization, and add CMC to French Guidelines
#2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use constraintDecl for Schematron namespace declarations in tei_customization * Use constraintDecl (instead of hack constraintSpecs) in the Guidelines (both en & fr) * Added CMC to fr Guidelines
sydb
requested review from
hcayless,
raffazizzi,
martindholmes,
sabineseifert,
HelenaSabel,
martinascholger and
joeytakeda
|
Looks good to me, but why do we still need the old Schematron namespace? |
|
Good question. Not at all sure that we do. (I just copied the namespace decls that we had.) |
|
It occurs to me to wonder what the Stylesheets will do with a chain in which some ODDs use the old declare-it-wherever-you-want approach to ns declaration and the new constraintDecl mechanism. @sydb Do you know? |
|
ATOP group tested this today, and everything works as intended, so we're good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes:
<constraintDecl>for Schematron namespace declarations in tei_customization<constraintDecl>(instead of hack<constraintSpecs>) in the Guidelines (both en & fr)WARNING:
This PR will not work against the released or current dev Stylesheets, but rather against the sydb_fix_constraintDecl_oversight_01 branch of the Stylesheets; and thus it should not be merged until (TEIC/Stylesheets#727) is merged!