Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs

[trishaoconnor]

Replaced 'break' with 'beginning' for page|line|column|gathering in the following files from the Guidelines and Specs:

-     page beginning (<pb>)
-     column beginning (<cb>)
-     att.breaking
-     parameter (<param>)
-     model (<model>)
-     att.edition
-     att.milestoneUnit
-     WD Non Standard Characters
-     SG Gentle Introduction
-     PH Primary Sources
-     NH Non Hierarchical
-     HD Header
-     FT Tables Formulae Graphics
-     DS Default Text Structure
-     DI Print Dictionaries
-     CO Core Elements
-     CH Language Character Sets

There were no mentions of 'break' in the prose of <gb> but I deleted an superfluous space in the prose

The requested changes to <lb> are addressed in PR #2633.

[ebeshero]

@sydb Might as well have a look at this while you're at it?

[sydb]

The majority of my suggestions for change, here, are underpinned by my strong distaste for using the noun “beginning” unless it is being used to gloss an element itself or very specifically about the beginning of a feature. Others may disagree.

[sydb]

This use of the term has nothing to do with our <lb> element, and perhaps should just be left as “line break”. (Note the space — 18 of the 25 occurences of "line.?break" in the Guidelines have a space. (One has a hyphen, and six have the single word version.)

[trishaoconnor]

Further down on line 353, "line division" is used. For consistency, I've rewritten line 332 using "division" instead of "beginning" and "break". Hopefully, this substitution is acceptable?

"Any case where the word is hyphenated across a linebreak..."

Thank you very much, too, for spotting the different renderings of the term throughout the Guidelines.

[sydb]

Seems fine. But with respect to the different renderings of the term, no pat on the back for just finding them; I have not gone out and fixed them, yet. 😄

[trishaoconnor]

I searched using the query that @martinascholger kindly provided when opening the issue. I thought that this would have caught every instance, including variations between line-break, line break and linebreak?
(page|line|column|gathering)[\s-]*breaks
I'll search for the occurrences that you found an fix them too. :)

[sydb]

Depends on what regular expression language you are using, I think. (I am not sure on this, but I think in most languages “\s”, when inside square brackets, means “whitespace”; but in some languages means “an ‘s’”. It would be quite conceivable that it means “a backslash or an ‘s”’, too.)

[martindholmes]

@trishaoconnor Just letting you know I've just cherry-picked a single-character commit fix from dev into this branch just to make sure it didn't cause any issues. It was a typo in the boustrophedon section of WD-NonStandardCharacters.xml which just needed an added s, found by @sydb. Doesn't affect any of the other stuff in your branch.

[trishaoconnor]

Thank you very much @sydb for your thorough review and thank you too @martindholmes for fixing that typo and merging it to the PR.

I appreciate your point @sydb and thank you very much for highlighting the passages where "beginning" isn't an appropriate substitution for "break". I confess that I still have a preference for using "beginning" instead of "break" and would be in favour of rewriting these passages along similar lines to the example that you supplied above:

<p>In the following lines from the <title level="a">Dream of the Rood</title>, the words <mentioned>lāðost</mentioned> and <mentioned>reord-berendum</mentioned> each start on one line and continue on the next.</p>

Of course, if the general consensus is to revert to "break" instead, I'll happily do so.

[ebeshero]

I'm just merging this now, as it's ready to go for the release.