Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix description by restoring lost value #2579

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

rettinghaus
Copy link
Contributor

Small fix for Chinese description in gap where obviously one value got lost. Restored it from the similar Korean description.

Copy link
Member

@peterstadler peterstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR reintroduces a missing value (which was deleted in 05323e6), I think the more accurate way would be to remove the sample values from the <desc> completely as it is the case with other languages like English an Spanish. Here, the terms of the sample values are given in translation in the <gloss> to the <valItem>s:

<valList type="semi">
<valItem ident="cancelled">
<gloss xml:lang="en" versionDate="2017-02-06">cancelled</gloss>
<gloss versionDate="2017-02-06" xml:lang="de">abgebrochen</gloss>
<gloss versionDate="2017-02-06" xml:lang="it">cancellato</gloss>
<gloss versionDate="2017-02-06" xml:lang="es">cancelado</gloss>
<gloss versionDate="2017-02-06" xml:lang="fr">biffé</gloss>
</valItem>
<valItem ident="deleted">
<gloss xml:lang="en" versionDate="2017-02-07">deleted</gloss>
<gloss versionDate="2017-02-07" xml:lang="de">getilgt</gloss>
</valItem>
<valItem ident="editorial">
<gloss xml:lang="en" versionDate="2021-02-01">editorial</gloss>
<desc versionDate="2017-02-06" xml:lang="en">for features omitted from
transcription due to editorial policy</desc>
<desc versionDate="2017-02-07" xml:lang="de">für Bestandteile,
die aus editorischen Gründen nicht übertragen wurden</desc>
</valItem>
<valItem ident="illegible">
<gloss xml:lang="en" versionDate="2017-02-06">illegible</gloss>
<gloss versionDate="2017-02-07" xml:lang="de">unleserlich</gloss>
<gloss versionDate="2017-02-06" xml:lang="it">illegibile</gloss>
<gloss versionDate="2017-02-06" xml:lang="es">ilegible</gloss>
<gloss versionDate="2017-02-06" xml:lang="fr">illisible</gloss>
</valItem>
<valItem ident="inaudible">
<gloss xml:lang="en" versionDate="2017-02-06">inaudible</gloss>
<gloss versionDate="2017-02-06" xml:lang="de">nicht hörbar</gloss>
<gloss versionDate="2017-02-06" xml:lang="it">incomprensibile</gloss>
<gloss versionDate="2017-02-06" xml:lang="es">inaudible</gloss>
<gloss versionDate="2017-02-06" xml:lang="fr">inaudible</gloss>
</valItem>
<valItem ident="irrelevant">
<gloss xml:lang="en" versionDate="2017-02-06">irrelevant</gloss>
<gloss versionDate="2017-02-06" xml:lang="de">irrelevant</gloss>
<gloss versionDate="2017-02-06" xml:lang="it">irrilevante</gloss>
<gloss versionDate="2017-02-06" xml:lang="es">irrelevante</gloss>
<gloss versionDate="2017-02-06" xml:lang="fr">non pertinent</gloss>
</valItem>
<valItem ident="sampling">
<gloss xml:lang="en" versionDate="2017-02-06">sampling</gloss>
<gloss versionDate="2017-02-06" xml:lang="de">Auswahl</gloss>
<gloss versionDate="2017-02-06" xml:lang="it">campionatura</gloss>
<gloss versionDate="2017-02-06" xml:lang="es">ejemplificación</gloss>
<gloss versionDate="2017-02-06" xml:lang="fr">échantillonnage</gloss>
</valItem>
</valList>

@rettinghaus
Copy link
Contributor Author

Then this should be done by someone who actually speaks these languages.

@sydb
Copy link
Member

sydb commented Nov 27, 2024

Note that this PR is (as far as @trishaoconnor and I are concerned) is a GO for merge, but @peterstadler is right, we should find people who speak Korean and Taiwanese to correct the descriptions by removing the enumeration of values and whatever bit before them would no longer belong.

@sydb
Copy link
Member

sydb commented Jan 20, 2025

Merging in this fix, and opening new ticket with @peterstadler’s (correct, IMHO) suggestion.

@sydb sydb closed this Jan 20, 2025
@sydb sydb reopened this Jan 20, 2025
@sydb sydb merged commit 3c89ad9 into TEIC:dev Jan 20, 2025
2 checks passed
@rettinghaus rettinghaus deleted the fix/typo branch January 20, 2025 19:39
@sydb
Copy link
Member

sydb commented Jan 20, 2025

See #2663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants