Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix an abstract model violation msg #2559

Merged
merged 133 commits into from
Jan 21, 2025
Merged

fix an abstract model violation msg #2559

merged 133 commits into from
Jan 21, 2025

Conversation

sydb
Copy link
Member

@sydb sydb commented May 19, 2024

This is intended to address #2497. As a side effect, it simplifies the Schematron, too.

  • Updated Schematron as per issue
  • Added a test to detest.xml
  • Updated expected results to match new test file

@sydb
Address #2497:
331cb41 
 * Updated Schematron as per issue
 * Added a test to detest.xml
 * Updated expected results to match new test file
@sydb sydb added this to the Guidelines 4.8.0 milestone May 19, 2024
@sydb sydb requested review from torstenroeder and GusRiva May 19, 2024 03:55
rettinghaus and others added 18 commits July 16, 2024 19:11
@rettinghaus
compactify specGrps
00bda9c
@rettinghaus
remove whitespace in processing instructions
d0b6402
@rettinghaus
make emph member of att.written
dc91c79
@rettinghaus
remove outdated definitions of hand atrribute
21644bf
@rettinghaus
add German description
abfd97d
@rettinghaus
remove outdated content
6f9da32
@rettinghaus
fix versionDate
978e7a9
@rettinghaus
style: minor formatting
425c87a
@rettinghaus
fix: typo
72a9352
@rettinghaus
style: unify French descriptions
76393c7
@rettinghaus
style: unify English and German descriptions
1e02aa7
@rettinghaus
fix: cleaning up some overlooked cases
1e159bf
@sydb
Start of first crack, NOT READY for prime-
66f7ea3 
time yet.
@sydb
Merge in latest from dev
94ea0d3
@sydb
First crack at new constraintDecl element in
96b051b 
a working, if not ideal, state
@sydb
Add “only 1 constraintDecl per scheme” constraint
8d39266
@sydb
Update TEI-to-tei_customization.xslt to handle new
b7fd3e9 
constraintDecl element
@sydb
Bug (noticed by @raffazizzi) fix: allow 0+ anyElement content of cons…
b43f4df 
…traintDecl
torstenroeder
torstenroeder reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@torstenroeder torstenroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look right to me. What about the checks? Do they need to pass before approval?

torstenroeder and others added 26 commits January 14, 2025 12:54
@torstenroeder
Merge pull request #2633 from TEIC/trishaoconnor_2367
be61efe 
Updated specs for `<line>` and `<lb>`
@martindholmes
Normalizing Japanese punctuation per issue #2337. (#2648)
ba43ca5
@sydb
Emergency fix: extended lifetime of
ecf0b7c 
"context-required" deprecation warning for 1 month so
we do not get errors until after release next week.
@trishaoconnor
Apply recommended update to att.breaking
536a267
@trishaoconnor
Apply recommended changes toWD-NonStandardCharacters
b2c4465
@trishaoconnor
Apply recommended changes toWD-NonStandardCharacters
5f2fedf
@trishaoconnor
Applied recommended changes to CO-CoreElements
eaa34d6
@trishaoconnor
Applied recommended changes to DI-PrintDictionaries
324be44
@trishaoconnor
Applied recommended changes to DS-DefaultTextStructure
65d9eac
@trishaoconnor
Applied recommended changes to FT-TablesFormulaeGraphics
0ae161d
@trishaoconnor
Applied recommended changes to PH-PrimarySources
f7faf25
@trishaoconnor
Applied recommended changes to SG-GentleIntroduction
8618a90
@trishaoconnor
Changed 'beginning' back to 'break' in model.xml and param.xml
169067c
@sydb
Impliment @hcayless solution #1
5972b28
@sydb
Ack! Forgot to
371266e 
update tests to match.
@trishaoconnor
Added missing Oxford comma
fb8a4a4
@trishaoconnor
Rewrite line beginning section
861b9ba
@trishaoconnor
Change linebreaks to line divisions
14e2fbb
@trishaoconnor
dev updates
4de687a
@martindholmes
Remove space in the middle of a word.
8157876
@rettinghaus
fix: restore lost value (#2579)
3c89ad9
@ebeshero
Merge pull request #2634 from TEIC/trishaoconnor_2603
2c69230 
Replaced 'break' with 'beginning' for page|line|column|gathering in Guidelines and Specs
@ebeshero
Merge pull request #2662 from TEIC/sydb_2246_check_spanning_only_in_c…
2a2ba2b 
…urrent_document

Implement @hcayless solution #1 for issue @2246 — do not test `@spanTo` across files
@sydb
Rebased (with several manual merges and a fix to expected results) of:
4bd774d 
Address #2497:
 * Updated Schematron as per issue
 * Added a test to detest.xml
 * Updated expected results to match new test file
@sydb
manual merge
705d922
@sydb
manual merge of expected results
32bbed2
ebeshero
ebeshero approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now tested this thoroughly, including building the tei_all and testing it on an epigraph. All good.

@ebeshero ebeshero merged commit 052a340 into dev Jan 21, 2025
2 checks passed
@sydb sydb mentioned this pull request Jan 21, 2025
Closed
@ebeshero ebeshero deleted the sydb_2497_p_in_epigraph_in_lg_is_OK branch January 21, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torstenroeder torstenroeder torstenroeder left review comments

@ebeshero ebeshero ebeshero approved these changes

@GusRiva GusRiva Awaiting requested review from GusRiva

Assignees

@ebeshero ebeshero

Labels
Status: Pending pending action described in a comment, to return to discussion before further action will be taken TEI: Guidelines & Documentation Type: Bug
Projects
None yet
Milestone
Guidelines 4.9.0
Development

Successfully merging this pull request may close these issues.