Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reg.xml #2527

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Update reg.xml #2527

merged 5 commits into from
Mar 16, 2024

Conversation

knagasaki
Copy link
Contributor

No description provided.

@trishaoconnor trishaoconnor self-assigned this Feb 14, 2024
@trishaoconnor trishaoconnor added this to the Guidelines 4.8.0 milestone Feb 14, 2024
@sydb sydb requested a review from martindholmes February 28, 2024 16:17
Copy link
Contributor

@martindholmes martindholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cit.xml では「引用内容」というglossについてなんですけど:普通の使い方では<cit>は引用として子要素の<quote>は引用の内容を示すではありませんか。
cl.xmlのでは、"relative clause"というのは「連体修飾」より「関係節」をよく見たことがありますが、「連体修飾」でもいいかもしれません。
僕は誤解や間違いしてしまってごめんなさい。

@tuurma
Copy link
Contributor

tuurma commented Mar 16, 2024

@knagasaki f2f subgroup cannot judge the merit of Martin's suggestions, would you like to respond to them and should we treat this PR as a Work in Progress or shall we try to merge it as soon as possible and further amendments and extensions can be brought in as a separate PR.

@tuurma
Copy link
Contributor

tuurma commented Mar 16, 2024

@knagasaki apart from the main body of the contributions, current version seems to be conflicting with the dev branch, if you could try to resolve these, it would be easier to merge for us

@martindholmes
Copy link
Contributor

@tuurma My comments are just queries about two vocabulary choices, and shouldn't be viewed as blocking if you need to get this merged before a release; I may not actually know what I'm talking about. :-)

@tuurma
Copy link
Contributor

tuurma commented Mar 16, 2024

This is what we assumed, that vocabulary adjustments should not block the progress made already. Resolving merge conflicts though would be very helpful. Though these seem pretty straightforward, so person merging can probably do it too.

@knagasaki
Copy link
Contributor Author

cit.xml では「引用内容」というglossについてなんですけど:普通の使い方では<cit>は引用として子要素の<quote>は引用の内容を示すではありませんか。 cl.xmlのでは、"relative clause"というのは「連体修飾」より「関係節」をよく見たことがありますが、「連体修飾」でもいいかもしれません。 僕は誤解や間違いしてしまってごめんなさい。

I'm sorry for my late reply. Thank you for checking the translations.
Our thoughts on the two points are:

  1. 「引用内容」in cit.xml attempts to translate "cited quotation" in English.
  2. In cl.xml, as「連体修飾」 is more general than 「関係節」, some linguists in the translation team selected the word.

@ebeshero
Copy link
Member

Council at VF2F asks @tuurma to update this branch, as she can easily resolve the conflict and merge.

@tuurma tuurma merged commit 5b51ae9 into TEIC:dev Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants