-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 19 new GPR and consolidate curations between model releases #313
Conversation
You should make new feature branches of a recent In addition, please do not modify existing curation files, but make new file/folders in |
I have rebased this onto the most recent
|
…_GPR # Conflicts: # README.md # code/modelCuration/addDBNewGeneAnnotation.m # model/yeast-GEM.xml # model/yeast-GEM.yml
# Conflicts: # README.md # code/modelCuration/addDBNewGeneAnnotation.m # model/dependencies.txt # model/yeast-GEM.xml # model/yeast-GEM.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run /code/modelCuration/v8_6_0.m
to test the consolidated curation of #305, #306 and this PR. This new curation pipeline is introduced here, let's test it out for a while to see whether it functions well.
Otherwise, there are a few concerns to look at, @cheng-yu-zhang @feiranl.
@edkerk When I run "/code/modelCuration/v8_6_0.m", I find that there is a extra parameter "grRatioMuts" in line 44 of the "essentialGenes.m", which may cause some issues. |
Great, this behaviour of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Note that all changes should be documented in a script, see for instance:
yeast-GEM/code/modelCuration/v8_6_0.m
Lines 55 to 57 in 43d4d14
model = setParam(model,'lb','r_4232',-1000); model = setParam(model,'rev','r_4232',1); model = removeReactions(model,'r_4566',true,true,true); - Note that removal of a reaction remains complete removal, not just blocking by setting LB and UB to 0, so not:
Line 3927 in eab45b9
r_4566 6-phospho-D-gluconate[c] + ADP[c] + H+[c] => ATP[c] + D-gluconate[c] YDR248C 0.00 0.00 0.00
Main improvements in this PR:
Add 19 new GPR accoording to SGD and uniprot.
This PR is used to demonstrate consolidation of multiple curations in one script, that can convert a previous model release to the next version.
I hereby confirm that I have:
develop
as a target branch (top left drop-down menu)