Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantom support for Playwright #1271

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Phantom support for Playwright #1271

wants to merge 6 commits into from

Conversation

zgz2020
Copy link
Collaborator

@zgz2020 zgz2020 commented Feb 15, 2025

Pull Request Title

Adding Phantom wallet support for Playwright

Description

This pull request adds Phantom support for Playwright.

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ❌ Failed (Inspect) Feb 15, 2025 0:13am

/**
* The password of the Phantom wallet.
*/
readonly password: string,

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'password' is useless, since
another property write
always overrides it.
@zgz2020 zgz2020 force-pushed the phantom-playwright branch 3 times, most recently from b341e2d to f20bfd2 Compare February 19, 2025 18:53
@zgz2020 zgz2020 marked this pull request as ready for review February 20, 2025 21:20
@zgz2020 zgz2020 requested a review from drptbl February 20, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant