Skip to content

Conversation

@mreid-tt
Copy link
Contributor

@mreid-tt mreid-tt commented Oct 30, 2025

Summary
This update modernises the project configuration and dependencies to align with current specifications and framework updates.

Changes

  • Updated project definition file to the latest specification
  • Updated all project dependencies to their current stable versions
  • Completed migration of the registration form to RegisterFormV2
  • Refreshed .pre-commit-config.yaml with the latest versions of referenced repositories
  • Used modern Flask-SQLAlchemy db.get_or_404() API instead of legacy Query.get_or_404()
  • Bump project to Python 3.12 and removed unused dependencies

@mreid-tt mreid-tt force-pushed the dependency-update branch 3 times, most recently from 8614d76 to d466352 Compare October 30, 2025 22:58
@mreid-tt mreid-tt self-assigned this Oct 30, 2025
@mreid-tt
Copy link
Contributor Author

Hey @publicarray, I've opened this PR to bring spkrepo and its build environment up to the latest specifications. I’d like to merge and deploy this as a stable baseline before introducing new functionality to the repository server.

Let me know if you’re available to help with review, testing, and deployment.

@mreid-tt mreid-tt added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Oct 30, 2025
@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 1, 2025

Hey @publicarray, would now be a good time to consider moving to Python 3.12? I've gotten the build warnings down to three. All three warnings go away when we upgrade from Python 3.11 to 3.12. What are your thoughts here?

@mreid-tt mreid-tt force-pushed the dependency-update branch 2 times, most recently from f9c6ec4 to 4a9f17f Compare November 1, 2025 10:40
@mreid-tt mreid-tt force-pushed the dependency-update branch 2 times, most recently from b78d376 to cc4baa0 Compare November 1, 2025 13:23
Also remove unused dependencies
@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 1, 2025

Hey @publicarray, I've gone ahead and migrated the project to Python 3.12. I've also pruned some unused dependencies so we are neat and tidy. All tests report: 143 passed with no warnings.

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 4, 2025

Hey @Diaoul, I don't know if you may have time to help review and deploy this PR. I'm preparing to work on #91 and #157 and would like to establish a clean baseline with this PR to build upon.

@Diaoul
Copy link
Member

Diaoul commented Nov 4, 2025

I'd say go ahead and merge! Better this than the status-quo. As for deploying, I have access to a new VPS, I can grant you root access there.

One idea I had was to deport the storage that is currently hardcoded to filepaths to a Minio instance deployed as part of the Docker deployment, I guess switching VPS would be a good opportunity for such a change.

@mreid-tt
Copy link
Contributor Author

mreid-tt commented Nov 4, 2025

I'd say go ahead and merge! Better this than the status-quo. As for deploying, I have access to a new VPS, I can grant you root access there.

Ok, I can go ahead and merge but would have really liked it to be in production as well. For the new VPS, I know we discussed some initial migration strategies in #118. Did you confirm the new VPS has a CDN facility similar to the existing Fastly we use?

One idea I had was to deport the storage that is currently hardcoded to filepaths to a Minio instance deployed as part of the Docker deployment, I guess switching VPS would be a good opportunity for such a change.

I'm not deeply familiar with the existing VPS so I can only theorise what a migration could look like. I would need to have some discussions with @publicarray or yourself to better understand what is there now. However a fresh setup in the new VPS would be a useful way to test new features before cutting over.

@mreid-tt mreid-tt merged commit 6ee0179 into SynoCommunity:main Nov 5, 2025
2 checks passed
@mreid-tt mreid-tt deleted the dependency-update branch November 5, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants