-
-
Notifications
You must be signed in to change notification settings - Fork 25
Modernise project codebase and update dependencies #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8614d76 to
d466352
Compare
|
Hey @publicarray, I've opened this PR to bring Let me know if you’re available to help with review, testing, and deployment. |
|
Hey @publicarray, would now be a good time to consider moving to Python 3.12? I've gotten the build warnings down to three. All three warnings go away when we upgrade from Python 3.11 to 3.12. What are your thoughts here? |
f9c6ec4 to
4a9f17f
Compare
Re-implements test removed by SynoCommunity@49b9cba
b78d376 to
cc4baa0
Compare
Also remove unused dependencies
cc4baa0 to
20a21c7
Compare
|
Hey @publicarray, I've gone ahead and migrated the project to Python 3.12. I've also pruned some unused dependencies so we are neat and tidy. All tests report: |
|
I'd say go ahead and merge! Better this than the status-quo. As for deploying, I have access to a new VPS, I can grant you root access there. One idea I had was to deport the storage that is currently hardcoded to filepaths to a Minio instance deployed as part of the Docker deployment, I guess switching VPS would be a good opportunity for such a change. |
Ok, I can go ahead and merge but would have really liked it to be in production as well. For the new VPS, I know we discussed some initial migration strategies in #118. Did you confirm the new VPS has a CDN facility similar to the existing Fastly we use?
I'm not deeply familiar with the existing VPS so I can only theorise what a migration could look like. I would need to have some discussions with @publicarray or yourself to better understand what is there now. However a fresh setup in the new VPS would be a useful way to test new features before cutting over. |
Summary
This update modernises the project configuration and dependencies to align with current specifications and framework updates.
Changes
RegisterFormV2.pre-commit-config.yamlwith the latest versions of referenced repositoriesdb.get_or_404()API instead of legacyQuery.get_or_404()