Skip to content

phpunit 10 rewrite #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

phpunit 10 rewrite #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"require-dev": {
"phpunit/phpunit": "^9.0",
"phpunit/phpunit": "^10.0",
"phpstan/phpstan": "^1.9"
},
"scripts": {
Expand Down
53 changes: 22 additions & 31 deletions test/BrowserlessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\Exception\ClientException;

use GuzzleHttp\Middleware;
use SynergiTech\ChromePDF\Browserless;
use SynergiTech\ChromePDF\Browserless\APIException;
use SynergiTech\ChromePDF\Chrome;
Expand Down Expand Up @@ -85,37 +85,14 @@ public function test_timeout()

public function test_displayHeaderFooter()
{
$client = $this->getMockedClient();
$requests = [];

$client->expects($this->exactly(6))
->method('post')
->withConsecutive(
[
$this->anything(),
$this->logicalNot($this->hasKeyValue(['json', 'options', 'displayHeaderFooter']))
],
[
$this->anything(),
$this->hasKeyValue(['json', 'options', 'displayHeaderFooter'], $this->isTrue())
],
[
$this->anything(),
$this->hasKeyValue(['json', 'options', 'displayHeaderFooter'], $this->isFalse())
],
[
$this->anything(),
$this->hasKeyValue(['json', 'options', 'displayHeaderFooter'], $this->isTrue())
],
[
$this->anything(),
$this->hasKeyValue(['json', 'options', 'displayHeaderFooter'], $this->isTrue())
],
[
$this->anything(),
$this->hasKeyValue(['json', 'options', 'displayHeaderFooter'], $this->isFalse())
]
)
->willReturn(new Response());
$handlerStack = HandlerStack::create(new MockHandler(array_fill(0, 6, new Response())));
$handlerStack->push(Middleware::history($requests));

$client = new Client([
'handler' => $handlerStack,
]);

$bl = new Browserless(client: $client);
$bl->renderContent('test');
Expand All @@ -135,6 +112,20 @@ public function test_displayHeaderFooter()

$bl->setFooter(null);
$bl->renderContent('test');

$this->assertCount(6, $requests);

$requests = array_map(fn ($r) => json_decode((string) $r['request']->getBody(), true), $requests);

$options = array_column($requests, 'options');

$this->assertArrayNotHasKey('displayHeaderFooter', $options[0]);

$this->assertTrue($options[1]['displayHeaderFooter']);
$this->assertFalse($options[2]['displayHeaderFooter']);
$this->assertTrue($options[3]['displayHeaderFooter']);
$this->assertTrue($options[4]['displayHeaderFooter']);
$this->assertFalse($options[5]['displayHeaderFooter']);
}

public function test_header()
Expand Down
8 changes: 4 additions & 4 deletions test/ChromeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ private function getMockedProcess()
private function getMockedPDF()
{
return $this->getMockBuilder(Chrome::class)
->setMethods(['createProcess'])
->onlyMethods(['createProcess'])
->getMock();
}

Expand All @@ -40,7 +40,7 @@ public function test_callsSpecifiedBinary()
{
$pdf = $this->getMockBuilder(Chrome::class)
->setConstructorArgs(['test-pdf-binary'])
->setMethods(['createProcess'])
->onlyMethods(['createProcess'])
->getMock();

$pdf->expects($this->once())
Expand Down Expand Up @@ -216,7 +216,7 @@ public function test_displayHeaderFooter()
public function test_header()
{
$pdfBuilder = $this->getMockBuilder(Chrome::class)
->setMethods(['createProcess']);
->onlyMethods(['createProcess']);

$pdf = $pdfBuilder->getMock();
$pdf->expects($this->exactly(2))
Expand Down Expand Up @@ -261,7 +261,7 @@ public function test_header()
public function test_footer()
{
$pdfBuilder = $this->getMockBuilder(Chrome::class)
->setMethods(['createProcess']);
->onlyMethods(['createProcess']);

$pdf = $pdfBuilder->getMock();
$pdf->expects($this->exactly(2))
Expand Down
2 changes: 1 addition & 1 deletion test/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public function hasKeyValue($key, $constraint = null)
protected function getMockedClient()
{
return $this->getMockBuilder(Chrome::class)
->setMethods(['post'])
->addMethods(['post'])
->getMock();
}
}