Fix: SBML export and Model tab frontend-backend connection #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-flower-0c36fd81e-403.westus2.5.azurestaticapps.net |
There was a problem hiding this comment.
Pull request overview
Improves resilience of SBML export and the Model tab’s frontend-backend integration by adding safer error handling and sanitization.
Changes:
- Frontend: show an in-UI error when simulation config fails to load; avoid throwing when defaults are missing.
- Backend: return 400 for unknown
/data/*paths; make SBML event IDs safe; ensure conversion failures always return a non-null message.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SBOLCanvasFrontend/src/app/model-editor/model-editor.component.ts | Handles simulation config load errors and provides fallback defaults instead of throwing. |
| SBOLCanvasFrontend/src/app/model-editor/model-editor.component.html | Displays a Model tab error banner when config load fails. |
| SBOLCanvasFrontend/src/app/model-editor/model-editor.component.css | Styles the config-load error banner. |
| SBOLCanvasBackend/src/utils/MxToSBML.java | Sanitizes SBML event IDs to prevent invalid/empty identifiers. |
| SBOLCanvasBackend/src/servlets/Data.java | Returns 400 when /data/* path doesn’t match a supported endpoint. |
| SBOLCanvasBackend/src/servlets/Convert.java | Avoids null error messages in conversion error responses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SBOLCanvasFrontend/src/app/model-editor/model-editor.component.html
Outdated
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-flower-0c36fd81e-403.westus2.5.azurestaticapps.net |
cjmyers
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling for SBML export and Model tab frontend-backend connection.