Skip to content

Conversation

MilesCranmer
Copy link
Member

@jyothis-fp this should fix the issue you encountered that prevented passing guesses with normal operators, such as "x ^ 2" => "safe_pow(x, 2)".

Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.67%. Comparing base (2c8d3ca) to head (9e129d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   96.66%   96.67%           
=======================================
  Files          30       30           
  Lines        2612     2614    +2     
=======================================
+ Hits         2525     2527    +2     
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Aug 31, 2025

Benchmark Results (Julia v1)

Time benchmarks
master b2e17c6... master / b2e17c6...
eval/ComplexF32/evaluation 7.26 ± 0.54 ms 7.23 ± 0.55 ms 1 ± 0.11
eval/ComplexF64/evaluation 10.7 ± 0.79 ms 10.8 ± 0.85 ms 0.997 ± 0.11
eval/Float32/derivative 11.7 ± 0.59 ms 11.6 ± 0.68 ms 1.01 ± 0.078
eval/Float32/derivative_turbo 11.8 ± 0.74 ms 11.6 ± 0.72 ms 1.01 ± 0.09
eval/Float32/evaluation 2.79 ± 0.29 ms 2.73 ± 0.26 ms 1.02 ± 0.14
eval/Float32/evaluation_bumper 0.613 ± 0.018 ms 0.613 ± 0.019 ms 1 ± 0.042
eval/Float32/evaluation_turbo 0.528 ± 0.031 ms 0.537 ± 0.03 ms 0.984 ± 0.08
eval/Float32/evaluation_turbo_bumper 0.611 ± 0.017 ms 0.612 ± 0.018 ms 0.998 ± 0.04
eval/Float64/derivative 14.9 ± 1.1 ms 14.8 ± 1.2 ms 1 ± 0.11
eval/Float64/derivative_turbo 14.7 ± 1 ms 14.8 ± 0.95 ms 0.994 ± 0.093
eval/Float64/evaluation 3.21 ± 0.35 ms 3.15 ± 0.36 ms 1.02 ± 0.16
eval/Float64/evaluation_bumper 1.26 ± 0.046 ms 1.26 ± 0.043 ms 1 ± 0.049
eval/Float64/evaluation_turbo 1.02 ± 0.063 ms 1.02 ± 0.065 ms 0.998 ± 0.089
eval/Float64/evaluation_turbo_bumper 1.26 ± 0.043 ms 1.27 ± 0.043 ms 0.998 ± 0.048
utils/combine_operators/break_sharing 0.0425 ± 0.0027 ms 0.0426 ± 0.0026 ms 0.997 ± 0.088
utils/convert/break_sharing 30.1 ± 4.6 μs 31 ± 4.9 μs 0.972 ± 0.21
utils/convert/preserve_sharing 0.105 ± 0.0083 ms 0.105 ± 0.0084 ms 0.994 ± 0.11
utils/copy/break_sharing 30.1 ± 3.7 μs 30.1 ± 4.9 μs 0.997 ± 0.2
utils/copy/preserve_sharing 0.106 ± 0.0094 ms 0.104 ± 0.0079 ms 1.02 ± 0.12
utils/count_constant_nodes/break_sharing 13.9 ± 2.2 μs 13.7 ± 2.2 μs 1.02 ± 0.23
utils/count_constant_nodes/preserve_sharing 0.0889 ± 0.0059 ms 0.0874 ± 0.0062 ms 1.02 ± 0.099
utils/count_depth/break_sharing 14.6 ± 2.1 μs 14.6 ± 2 μs 1 ± 0.2
utils/count_nodes/break_sharing 13.7 ± 2.2 μs 13 ± 1.8 μs 1.05 ± 0.22
utils/count_nodes/preserve_sharing 0.0885 ± 0.0066 ms 0.0882 ± 0.0066 ms 1 ± 0.11
utils/get_set_constants!/break_sharing 0.0349 ± 0.0035 ms 0.0354 ± 0.0047 ms 0.985 ± 0.16
utils/get_set_constants!/preserve_sharing 0.182 ± 0.0095 ms 0.182 ± 0.01 ms 0.997 ± 0.076
utils/get_set_constants_parametric 0.0505 ± 0.0064 ms 0.0513 ± 0.0073 ms 0.984 ± 0.19
utils/has_constants/break_sharing 8.19 ± 1.2 μs 8.23 ± 1.3 μs 0.994 ± 0.21
utils/has_operators/break_sharing 2.58 ± 0.2 μs 2.6 ± 0.2 μs 0.992 ± 0.11
utils/hash/break_sharing 25 ± 2.6 μs 24.6 ± 3.3 μs 1.02 ± 0.17
utils/hash/preserve_sharing 0.101 ± 0.0068 ms 0.103 ± 0.0076 ms 0.98 ± 0.098
utils/index_constant_nodes/break_sharing 31 ± 3.9 μs 30.5 ± 3.2 μs 1.02 ± 0.17
utils/index_constant_nodes/preserve_sharing 0.105 ± 0.0068 ms 0.105 ± 0.0072 ms 1 ± 0.095
utils/is_constant/break_sharing 8.66 ± 1.4 μs 8.58 ± 1.4 μs 1.01 ± 0.23
utils/simplify_tree/break_sharing 28.1 ± 3.5 μs 27.2 ± 3 μs 1.03 ± 0.17
utils/simplify_tree/preserve_sharing 0.109 ± 0.0065 ms 0.108 ± 0.007 ms 1.01 ± 0.089
utils/string_tree/break_sharing 0.491 ± 0.025 ms 0.5 ± 0.026 ms 0.981 ± 0.071
utils/string_tree/preserve_sharing 0.583 ± 0.025 ms 0.598 ± 0.022 ms 0.976 ± 0.055
time_to_load 0.228 ± 0.0033 s 0.23 ± 0.0043 s 0.991 ± 0.023
Memory benchmarks
master b2e17c6... master / b2e17c6...
eval/ComplexF32/evaluation 0.981 k allocs: 2.51 MB 0.981 k allocs: 2.51 MB 1
eval/ComplexF64/evaluation 0.996 k allocs: 5.07 MB 1.01 k allocs: 5.14 MB 0.988
eval/Float32/derivative 4.74 k allocs: 17.9 MB 4.7 k allocs: 17.7 MB 1.01
eval/Float32/derivative_turbo 4.54 k allocs: 17.1 MB 4.68 k allocs: 17.6 MB 0.971
eval/Float32/evaluation 0.975 k allocs: 1.27 MB 0.99 k allocs: 1.29 MB 0.985
eval/Float32/evaluation_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float32/evaluation_turbo 0.951 k allocs: 1.24 MB 0.972 k allocs: 1.27 MB 0.978
eval/Float32/evaluation_turbo_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float64/derivative 4.78 k allocs: 0.035 GB 4.77 k allocs: 0.0349 GB 1
eval/Float64/derivative_turbo 4.8 k allocs: 0.0351 GB 4.75 k allocs: 0.0347 GB 1.01
eval/Float64/evaluation 0.99 k allocs: 2.53 MB 1.01 k allocs: 2.58 MB 0.982
eval/Float64/evaluation_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
eval/Float64/evaluation_turbo 0.996 k allocs: 2.55 MB 0.978 k allocs: 2.5 MB 1.02
eval/Float64/evaluation_turbo_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
utils/combine_operators/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/convert/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/convert/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/copy/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/copy/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/count_constant_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_constant_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/count_depth/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/get_set_constants!/break_sharing 0.898 k allocs: 25.2 kB 0.898 k allocs: 25.2 kB 1
utils/get_set_constants!/preserve_sharing 1.7 k allocs: 0.138 MB 1.7 k allocs: 0.138 MB 1
utils/get_set_constants_parametric 1.42 k allocs: 0.0663 MB 1.42 k allocs: 0.0663 MB 1
utils/has_constants/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/has_operators/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/hash/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/hash/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/index_constant_nodes/break_sharing 2.1 k allocs: 0.094 MB 2.1 k allocs: 0.094 MB 1
utils/index_constant_nodes/preserve_sharing 2.5 k allocs: 0.163 MB 2.5 k allocs: 0.163 MB 1
utils/is_constant/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/simplify_tree/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/simplify_tree/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/string_tree/break_sharing 11.8 k allocs: 1.04 MB 11.8 k allocs: 1.04 MB 1
utils/string_tree/preserve_sharing 12.2 k allocs: 1.11 MB 12.2 k allocs: 1.11 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@MilesCranmer MilesCranmer merged commit d4b12df into master Aug 31, 2025
11 of 12 checks passed
@MilesCranmer MilesCranmer deleted the fix-alias-parsing branch August 31, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant