Add missing signal action descriptions to running.rst#1720
Open
krrishapatel wants to merge 2 commits into
Open
Add missing signal action descriptions to running.rst#1720krrishapatel wants to merge 2 commits into
krrishapatel wants to merge 2 commits into
Conversation
On Linux, signal numbers SIGRTMIN through SIGRTMAX (typically 34-64) are valid but have no named constants in the signal module. The existing list comprehension only collects SIG* attributes, causing signal_number() to reject real-time signals with "not a valid signal number". Extend SIGNUMS with the SIGRTMIN..SIGRTMAX range when those attributes are available.
The signal action documentation just said "No help on signal". Replace with proper descriptions matching the four usage patterns from supervisorctl's help_signal output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
signalaction inrunning.rstjust said "No help on signal" while every other action had proper descriptions. This adds the four signal usage patterns matching the output ofhelp_signalin supervisorctl:signal <signal name> <name>— Signal a processsignal <signal name> <gname>:*— Signal all processes in a groupsignal <signal name> <name> <name>— Signal multiple processes or groupssignal <signal name> all— Signal all processesFixes #1718