-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't cycle tab position by default anymore (and a few other cleanups) #3
base: master
Are you sure you want to change the base?
Conversation
It runs on any relevant ST version (with a tag prefix for versions pre-ST4).
Also update instructions on how to use suggested bindings to move to beginning and end.
I find this order easier to read.
I've forked this repo to https://github.com/deathaxe/MoveView years ago to
I never liked those string arguments here. Mixing them up with integers doesn't improve it. |
If compatibility is not an issue and separate commands as in MoveView are not desired, the API should IMHO at least look a bit more ST like by Move tab relative{ "command": "move_tab", "args": {"by": -1, "cycle": false} } Move tab to absolute position counting from first tab onwards{ "command": "move_tab", "args": {"to": 5} } Move tab to absolute position counting from last tab backwards{ "command": "move_tab", "args": {"to": -5} } |
That is indeed the biggest question here. So far, aside from the cycling behavior, my changes are backwards compatible, but I agree that we can use this opportunity to make more changes I suspect that most users just use the default key bindings and haven't added their own. Even then, I could provide a backwards compatibility argument which would ensure everything works exactly as before when the old I'll think about it for a bit. |
I attempted to utilize this branch and encountered the following error:
I am uncertain why my Sublime Text editor - Build 4169, appears to be using Python 3.3. I'm on Pop!_OS 22.04 LTS. Any insights or suggestions on resolving this issue would be greatly appreciated. |
It's controlled by That said, assignment expressions are of little value here. |
Closes #2.
I'm breaking compatibility with older ST builds here because I believe they are not worth maintaining, so I created a PC PR for this: wbond/package_control_channel#8886
Tags are already pushed.
I chose to make behavior configurable via a command parameter because a setting would have been overkill and because you may want to have both modes simultaneously.