-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Traverse Reforged biomes to list for GT ore generation #56
base: forge-1.12.2
Are you sure you want to change the base?
Conversation
I did some more digging after coming across a biome I wasn't expecting. Here's a list of ALL of the traverse reforged biomes, dumped with TellMe mod. I can submit another pull request if you want, or you could add the missing ones in.
|
Thanks for the additions! I see it's been a while since I've written this.. perhaps it'd be better to rip out the hardcoded biome lists entirely and replace them with config options instead. But either way works tbh. |
Config options would certainly be the best solution since it would allow pack makers to decide what biomes get what ores and change the distribution settings for those ores if they desire. But given that most people playing this presumably want Gregtech balance, and BoP and Traverse Reforged are the most popular biome mods on 1.12.2 by far, I think either solution works. If it were me, I would put in the BoP + Traverse + Vanilla biomes as defaults, and add a config option to disable Gregtech ore generation per ore so that end users can set up their own custom generation with CoFH World if they so desire. If I knew how to program I'd submit a pull request but alas I just fumble around in the dark with ChatGPT/Google Gemini to guide me, so anything I whipped up would probably be a mess. |
Just adding Traverse Reforged biomes to the list since it's a fairly common biome mod for 1.12.2 that players are likely to use with or in place of Biomes O Plenty.
I sorted them by 'type' (Plains, Dry, Forest, Cold, Swampy) to stay in line with the established convention. You can browse through the descriptions of the biomes here if you want to check the classification I used and adjust them to your own liking.
Sorry 'bout the double commit. I be sloppy.