Skip to content

Generate project URLs correctly from SCM #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Apr 7, 2025

Maven's SCM inheritance assumes older style SVN style submodule paths by default, turning this off requries the use of a few XML attributes
See: https://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly

This change also updates the connection/developerConnection. When possible the 'connection' should be a public accessible URL (e.g. no-auth required https://github.com/...), and the developerConnection to the previously used ssh url
See: https://maven.apache.org/pom.html#SCM

Fixes: #32

Maven's SCM inheritance assumes older style SVN style submodule paths by default, turning this off requries the use of a few XML attributes
See: https://maven.apache.org/ref/3.6.1/maven-model-builder/#Inheritance_Assembly

This change also updates the connection/developerConnection. When possible the 'connection' should be a public accessible URL (e.g. no-auth required https://github.com/...), and the developerConnection to the previously used ssh url
See: https://maven.apache.org/pom.html#SCM

Fixes: StyraInc#32
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for making the changes!

@andreaTP andreaTP merged commit 70bd79e into StyraInc:main Apr 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven nitpicking
2 participants