Skip to content

WIP: Treat a string wrapped in a Promise as non-binary #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: Treat a string wrapped in a Promise as non-binary #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions test/asserts/file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,27 @@ QUnit.module("file", function () {
});
}

QUnit.test('add UTF-8 text without a Promise', async function (assert) {
var zip = new JSZip();
zip.file("file.html", "Hèllo");
const output = await zip.file("file.html").async("text");
assert.equal(output, "Hèllo");
});

QUnit.test('add UTF-8 text as a Promise with binary: false', async function (assert) {
var zip = new JSZip();
zip.file("file.html", Promise.resolve("Hèllo"), { binary: false });
const output = await zip.file("file.html").async("text");
assert.equal(output, "Hèllo");
});

QUnit.test('add UTF-8 text as a Promise without binary: false', async function (assert) {
var zip = new JSZip();
zip.file("file.html", Promise.resolve("Hèllo"));
const output = await zip.file("file.html").async("text");
assert.equal(output, "Hèllo");
});

QUnit.test("add file: file(name, polyfill Promise[string] as binary)", function (assert) {
var str2promise = function (str) {
return new JSZip.external.Promise(function(resolve, reject) {
Expand Down