Skip to content

Conversation

joshkel
Copy link

@joshkel joshkel commented Apr 8, 2024

ESLint 9 now requires that plugins provide a schema if they accept options; see https://eslint.org/blog/2024/04/eslint-v9.0.0-released/#changes-to-how-you-write-rules.

neuracr added a commit to google/safety-web that referenced this pull request Aug 6, 2024
Had to downgrade ESLint to v8 since the plugin is not compatible with
ESLint9 (yet?) Stuk/eslint-plugin-header#56

Change-Id: I85a07ce19f1a8c30ff65f2c010edea81bc9366f0
@tonyganchev
Copy link

@joshkel I have published the previous incremental fix to unblock work with ESLint9 - see #58. As I didn't get an approval on the PR, I had to publish from my fork: https://www.npmjs.com/package/@tony.ganchev/eslint-plugin-header.

Would you mind creating a PR for this fork until the owners of the original repo fix the CI/CD (if I understand the status of this PR correctly...)

tonyganchev pushed a commit to tonyganchev/eslint-plugin-header that referenced this pull request Jun 20, 2025
tonyganchev pushed a commit to tonyganchev/eslint-plugin-header that referenced this pull request Jun 20, 2025
@joshkel
Copy link
Author

joshkel commented Jul 7, 2025

Would you mind creating a PR for this fork until the owners of the original repo fix the CI/CD (if I understand the status of this PR correctly...)

Hey, @tonyganchev. Thanks for creating that fork. I apologize for not following up sooner. If I understand correctly, it looks like you already took care of this?

@tonyganchev
Copy link

Would you mind creating a PR for this fork until the owners of the original repo fix the CI/CD (if I understand the status of this PR correctly...)

Hey, @tonyganchev. Thanks for creating that fork. I apologize for not following up sooner. If I understand correctly, it looks like you already took care of this?

That's right. Thanks, and pardon me for not waiting for the response :)
So far the updated plugin works flawlessly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants