Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.3.7 #58

Merged

Conversation

degwinthegreat
Copy link

Why?

This PR relaxes the upper Ruby version constraint to support Ruby 3.3.7

scimaenaga-1.0.5 requires ruby version <= 3.3.6, >= 2.5.9, which is incompatible
with the current version, 3.3.7

https://www.ruby-lang.org/en/news/2025/01/15/ruby-3-3-7-released/

What?

Relax required_ruby_version

Copy link

@mtakeda15 mtakeda15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@mtakeda15
Copy link

It seems Ruby 3.3.7 is not supported yet. I guess we'll have to wait.
https://github.com/ruby/setup-ruby/blob/master/ruby-builder-versions.json

@degwinthegreat
Copy link
Author

degwinthegreat commented Jan 16, 2025

Thank you for your review!

The failing test seems to be related to this issue
actions/runner-images#11279

From this test, ubuntu seemed to have gone up from 22.04.5 to 24.04.1.

Log from this run

> Set up job
Current runner version: ‘2.321.0’
Operating System
  Ubuntu
  24.04.1
  LTS

https://github.com/StudistCorporation/scimaenaga/actions/runs/12787027869/job/35694697865

Log of last successful run.

> Set up job

Current runner version: ‘2.320.0’
Operating System
  Ubuntu
  22.04.5
  LTS

https://github.com/StudistCorporation/scimaenaga/actions/runs/11738822720/job/32702082566

Apparently a fixed version was released two days ago, but how to pull this image I have no idea.
https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20250113.1

@mtakeda15
Copy link

I fixed CI: #60

thanks!

@mtakeda15 mtakeda15 merged commit 5add55f into StudistCorporation:master Jan 17, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants